Paths

Table of Contentst

Support browsing '.' and default to it
ClosedPublic
Actions

Authored by sophiebits on Feb 9 2014, 1:24 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 17, 6:20 AM

	Unknown Object (File)
	Fri, Dec 13, 4:25 AM

	Unknown Object (File)
	Sun, Dec 8, 4:28 PM

	Unknown Object (File)
	Thu, Nov 28, 7:07 PM

	Unknown Object (File)
	Thu, Nov 28, 7:07 PM

	Unknown Object (File)
	Thu, Nov 28, 7:07 PM

	Unknown Object (File)
	Thu, Nov 28, 6:51 PM

	Unknown Object (File)
	Tue, Nov 26, 5:31 PM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC52d3cd1b4ef7: Support browsing '.' and default to it

Test Plan

Ran 'arc browse', 'arc browse .', 'arc browse main.py'.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

I'm not sure I'd like it to default to .; One thing I find myself doing quite often is:

$ find ... | xargs arc browse

Which would be a little weird (less "unix-y") if it will open the cwd instead of nothing, I think.

Kudos for the bug-fix, though :)

src/workflow/ArcanistBrowseWorkflow.php
79–80	can be written as `$this->getArgument('paths', '.');`

Maybe we could give you arc browse --stdin, although that might be a pain to remember.

I'll just pull the bugfix, I don't feel too strongly about the default behavior of arc browse, and the xargs use cases is a reasonable one.

Closed by commit rARC52d3cd1b4ef7 (authored by @spicyj, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistBrowseWorkflow.php

10 lines

Diff 18490

View Options

src/workflow/ArcanistBrowseWorkflow.php

Support browsing '.' and default to itClosedPublicActions