Page MenuHomePhabricator

Fix infinite loop in PhutilFileTree
ClosedPublic

Authored by sowedance on Jan 29 2014, 12:38 AM.
Tags
None
Referenced Files
F14799959: D8091.diff
Sat, Jan 25, 7:40 AM
Unknown Object (File)
Thu, Jan 23, 3:16 PM
Unknown Object (File)
Sun, Jan 12, 1:20 PM
Unknown Object (File)
Sat, Jan 11, 2:17 AM
Unknown Object (File)
Thu, Jan 2, 3:04 PM
Unknown Object (File)
Dec 7 2024, 5:20 PM
Unknown Object (File)
Dec 5 2024, 5:09 PM
Unknown Object (File)
Nov 30 2024, 3:47 AM

Details

Summary

In one of our diff we have files with name '10.8' and '10.80' in the same dir, which caused infinite loop since numerically they are the same hence getNextSibling() call on 10.80 will always gets itself.

Test Plan

Load the diff with fix.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline