Page MenuHomePhabricator

Add missing field to HeraldCommitAdapter
ClosedPublic

Authored by asherkin on Dec 21 2013, 6:11 PM.
Tags
None
Referenced Files
F13231838: D7814.diff
Tue, May 21, 12:48 AM
F13220480: D7814.diff
Sun, May 19, 1:32 AM
F13202560: D7814.diff
Tue, May 14, 10:50 PM
F13185296: D7814.diff
Sat, May 11, 2:46 AM
Unknown Object (File)
Tue, May 7, 5:05 AM
Unknown Object (File)
Fri, May 3, 2:30 AM
Unknown Object (File)
Mon, Apr 29, 1:56 PM
Unknown Object (File)
Wed, Apr 24, 9:53 PM

Details

Summary

This was added in D7807, but only added as a field to HeraldPreCommitContentAdapter.

Test Plan

Trusting D7807.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Ooops, haha -- I cowboy committed rPe27bbb, but it has the same tree hash as this once (since the change is identical) so it matched.

@mbishopim3, you should now be able to write a rule like this to detect "revision, but not accepted":

[Differential revision][exists]
[Accepted Differential revision][does not exist]
...
[Trigger an audit by][...]