Page MenuHomePhabricator

Add an "Accepted Differential revision" field to Commit and pre-commit Content Herald rules
ClosedPublic

Authored by epriestley on Dec 19 2013, 10:18 PM.
Tags
None
Referenced Files
F18906029: D7807.diff
Nov 8 2025, 4:36 PM
F18865860: D7807.id17672.diff
Nov 3 2025, 2:20 PM
F18758791: D7807.id17664.diff
Oct 5 2025, 11:42 PM
F18654266: D7807.id.diff
Sep 22 2025, 5:09 AM
F18653033: D7807.diff
Sep 21 2025, 10:44 AM
F18623811: D7807.id17672.diff
Sep 15 2025, 5:43 PM
F18562778: D7807.diff
Sep 9 2025, 4:55 AM
F18092675: D7807.diff
Aug 7 2025, 12:23 PM
Subscribers

Details

Summary

Refs T4195. Fixes T3936. You can't currently write rules like "block commits unless they're attached to an accepted revision"; allow that.

Test Plan

Pushed commits into a rule with this field, saw it work / not crash.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped