Page MenuHomePhabricator
Differential D7807

Add an "Accepted Differential revision" field to Commit and pre-commit Content Herald rules
ClosedPublic
Actions

Authored by epriestley on Dec 19 2013, 10:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 1 2026, 10:59 PM
Unknown Object (File)
Feb 19 2026, 6:23 PM
Unknown Object (File)
Feb 6 2026, 2:27 AM
Unknown Object (File)
Jan 10 2026, 1:06 AM
Unknown Object (File)
Jan 8 2026, 8:51 AM
Unknown Object (File)
Dec 26 2025, 7:40 PM
Unknown Object (File)
Dec 26 2025, 5:37 PM
Unknown Object (File)
Dec 17 2025, 1:20 AM
View All Files
Subscribers
aran
mbishopim3

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T4195: Implement pre-commit Herald rules
Commits
Restricted Diffusion Commit
rP72c73d644b0e: Add an "Accepted Differential revision" field to Commit and pre-commit Content…
Summary

Refs T4195. Fixes T3936. You can't currently write rules like "block commits unless they're attached to an accepted revision"; allow that.

Test Plan

Pushed commits into a rule with this field, saw it work / not crash.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
herald/
11 lines
herald/
adapter/
4 lines
10 lines

Diff 17672

View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldCommitAdapter.php

Loading...
Phabricator · Built by Phacility