Page MenuHomePhabricator

Add an "Accepted Differential revision" field to Commit and pre-commit Content Herald rules
ClosedPublic

Authored by epriestley on Dec 19 2013, 10:18 PM.
Tags
None
Referenced Files
F19508100: D7807.diff
Sat, Jan 10, 1:06 AM
F19493365: D7807.diff
Thu, Jan 8, 8:51 AM
F19376452: D7807.diff
Fri, Dec 26, 7:40 PM
F19373291: D7807.diff
Fri, Dec 26, 5:37 PM
F19210644: D7807.diff
Dec 17 2025, 1:20 AM
F18906029: D7807.diff
Nov 8 2025, 4:36 PM
F18865860: D7807.id17672.diff
Nov 3 2025, 2:20 PM
F18758791: D7807.id17664.diff
Oct 5 2025, 11:42 PM
Subscribers

Details

Summary

Refs T4195. Fixes T3936. You can't currently write rules like "block commits unless they're attached to an accepted revision"; allow that.

Test Plan

Pushed commits into a rule with this field, saw it work / not crash.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped