Page MenuHomePhabricator
Differential D7807

Add an "Accepted Differential revision" field to Commit and pre-commit Content Herald rules
ClosedPublic
Actions

Authored by epriestley on Dec 19 2013, 10:18 PM.
Tags
None
Referenced Files
F15577208: D7807.id.diff
Tue, May 6, 12:49 PM
F15538447: D7807.id17672.diff
Thu, Apr 24, 7:22 PM
F15527587: D7807.id.diff
Tue, Apr 22, 4:55 AM
F15513355: D7807.id.diff
Thu, Apr 17, 6:19 PM
F15418285: D7807.id17664.diff
Mar 20 2025, 10:17 PM
F15412894: D7807.id17664.diff
Mar 19 2025, 3:37 PM
F15396024: D7807.id17664.diff
Mar 16 2025, 11:18 AM
F15393186: D7807.id.diff
Mar 15 2025, 8:16 PM
View All Files
Subscribers
aran
mbishopim3

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T4195: Implement pre-commit Herald rules
Commits
Restricted Diffusion Commit
rP72c73d644b0e: Add an "Accepted Differential revision" field to Commit and pre-commit Content…
Summary

Refs T4195. Fixes T3936. You can't currently write rules like "block commits unless they're attached to an accepted revision"; allow that.

Test Plan

Pushed commits into a rule with this field, saw it work / not crash.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
herald/
11 lines
herald/
adapter/
4 lines
10 lines

Diff 17672

View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldCommitAdapter.php

Loading...
Phabricator · Built by Phacility