Page MenuHomePhabricator
Differential D7807

Add an "Accepted Differential revision" field to Commit and pre-commit Content Herald rules
ClosedPublic
Actions

Authored by epriestley on Dec 19 2013, 10:18 PM.
Tags
None
Referenced Files
F14068560: D7807.diff
Tue, Nov 19, 11:02 PM
F14055650: D7807.diff
Sat, Nov 16, 2:23 PM
F14043336: D7807.diff
Tue, Nov 12, 9:32 AM
F14033548: D7807.id17664.diff
Sat, Nov 9, 6:09 PM
F14025371: D7807.diff
Thu, Nov 7, 5:11 PM
F14013073: D7807.id17672.diff
Sat, Nov 2, 12:23 AM
F14011935: D7807.id.diff
Fri, Nov 1, 6:12 AM
F14011934: D7807.id17664.diff
Fri, Nov 1, 6:12 AM
View All Files
Subscribers
aran
mbishopim3

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T4195: Implement pre-commit Herald rules
Commits
Restricted Diffusion Commit
rP72c73d644b0e: Add an "Accepted Differential revision" field to Commit and pre-commit Content…
Summary

Refs T4195. Fixes T3936. You can't currently write rules like "block commits unless they're attached to an accepted revision"; allow that.

Test Plan

Pushed commits into a rule with this field, saw it work / not crash.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
herald/
11 lines
herald/
adapter/
4 lines
10 lines

Diff 17672

View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldCommitAdapter.php

Loading...
Phabricator · Built by Phacility