Page MenuHomePhabricator

Add missing field to HeraldCommitAdapter
ClosedPublic

Authored by asherkin on Dec 21 2013, 6:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 6:09 AM
Unknown Object (File)
Sat, Jan 4, 12:16 AM
Unknown Object (File)
Dec 27 2024, 8:31 PM
Unknown Object (File)
Dec 14 2024, 1:25 AM
Unknown Object (File)
Dec 12 2024, 10:35 AM
Unknown Object (File)
Dec 10 2024, 3:06 PM
Unknown Object (File)
Dec 9 2024, 9:21 AM
Unknown Object (File)
Nov 26 2024, 5:32 PM

Details

Summary

This was added in D7807, but only added as a field to HeraldPreCommitContentAdapter.

Test Plan

Trusting D7807.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Ooops, haha -- I cowboy committed rPe27bbb, but it has the same tree hash as this once (since the change is identical) so it matched.

@mbishopim3, you should now be able to write a rule like this to detect "revision, but not accepted":

[Differential revision][exists]
[Accepted Differential revision][does not exist]
...
[Trigger an audit by][...]