Page MenuHomePhabricator

Add missing field to HeraldCommitAdapter
ClosedPublic

Authored by asherkin on Dec 21 2013, 6:11 PM.
Tags
None
Referenced Files
F15544030: D7814.id17682.diff
Sat, Apr 26, 2:20 AM
F15532009: D7814.id.diff
Wed, Apr 23, 2:11 PM
F15529118: D7814.diff
Tue, Apr 22, 4:57 PM
F15428959: D7814.id17682.diff
Mar 23 2025, 11:42 PM
F15416461: D7814.diff
Mar 20 2025, 11:14 AM
Unknown Object (File)
Feb 24 2025, 12:54 AM
Unknown Object (File)
Feb 1 2025, 2:42 PM
Unknown Object (File)
Feb 1 2025, 4:58 AM

Details

Summary

This was added in D7807, but only added as a field to HeraldPreCommitContentAdapter.

Test Plan

Trusting D7807.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Ooops, haha -- I cowboy committed rPe27bbb, but it has the same tree hash as this once (since the change is identical) so it matched.

@mbishopim3, you should now be able to write a rule like this to detect "revision, but not accepted":

[Differential revision][exists]
[Accepted Differential revision][does not exist]
...
[Trigger an audit by][...]