Page MenuHomePhabricator

Add missing field to HeraldCommitAdapter
ClosedPublic

Authored by asherkin on Dec 21 2013, 6:11 PM.
Tags
None
Referenced Files
F14059460: D7814.diff
Sun, Nov 17, 7:47 PM
F14053032: D7814.diff
Fri, Nov 15, 12:14 PM
F14034752: D7814.diff
Sun, Nov 10, 2:03 AM
F14012211: D7814.diff
Fri, Nov 1, 8:47 AM
F14000561: D7814.diff
Thu, Oct 24, 10:53 PM
Unknown Object (File)
Oct 1 2024, 3:00 AM
Unknown Object (File)
Sep 26 2024, 12:57 PM
Unknown Object (File)
Sep 26 2024, 12:54 PM

Details

Summary

This was added in D7807, but only added as a field to HeraldPreCommitContentAdapter.

Test Plan

Trusting D7807.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Ooops, haha -- I cowboy committed rPe27bbb, but it has the same tree hash as this once (since the change is identical) so it matched.

@mbishopim3, you should now be able to write a rule like this to detect "revision, but not accepted":

[Differential revision][exists]
[Accepted Differential revision][does not exist]
...
[Trigger an audit by][...]