Page MenuHomePhabricator

Add missing field to HeraldCommitAdapter
ClosedPublic

Authored by asherkin on Dec 21 2013, 6:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 26 2025, 2:20 AM
Unknown Object (File)
Apr 23 2025, 2:11 PM
Unknown Object (File)
Apr 22 2025, 4:57 PM
Unknown Object (File)
Mar 23 2025, 11:42 PM
Unknown Object (File)
Mar 20 2025, 11:14 AM
Unknown Object (File)
Feb 24 2025, 12:54 AM
Unknown Object (File)
Feb 1 2025, 2:42 PM
Unknown Object (File)
Feb 1 2025, 4:58 AM

Details

Summary

This was added in D7807, but only added as a field to HeraldPreCommitContentAdapter.

Test Plan

Trusting D7807.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Ooops, haha -- I cowboy committed rPe27bbb, but it has the same tree hash as this once (since the change is identical) so it matched.

@mbishopim3, you should now be able to write a rule like this to detect "revision, but not accepted":

[Differential revision][exists]
[Accepted Differential revision][does not exist]
...
[Trigger an audit by][...]