Page MenuHomePhabricator

Add an "Accepted Differential revision" field to Commit and pre-commit Content Herald rules
ClosedPublic

Authored by epriestley on Dec 19 2013, 10:18 PM.
Tags
None
Referenced Files
F13897473: D7807.diff
Sun, Oct 6, 7:21 AM
Unknown Object (File)
Fri, Oct 4, 4:50 AM
Unknown Object (File)
Wed, Sep 11, 9:35 AM
Unknown Object (File)
Fri, Sep 6, 9:46 AM
Unknown Object (File)
Aug 31 2024, 11:40 AM
Unknown Object (File)
Aug 29 2024, 5:36 PM
Unknown Object (File)
Aug 29 2024, 5:36 PM
Unknown Object (File)
Aug 29 2024, 5:36 PM
Subscribers

Details

Summary

Refs T4195. Fixes T3936. You can't currently write rules like "block commits unless they're attached to an accepted revision"; allow that.

Test Plan

Pushed commits into a rule with this field, saw it work / not crash.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped