Page MenuHomePhabricator

Add an "Accepted Differential revision" field to Commit and pre-commit Content Herald rules
ClosedPublic

Authored by epriestley on Dec 19 2013, 10:18 PM.
Tags
None
Referenced Files
F17713537: D7807.diff
Thu, Jul 17, 2:12 PM
Unknown Object (File)
May 25 2025, 7:22 PM
Unknown Object (File)
May 20 2025, 8:19 PM
Unknown Object (File)
May 19 2025, 6:16 AM
Unknown Object (File)
May 9 2025, 7:21 AM
Unknown Object (File)
May 7 2025, 7:20 PM
Unknown Object (File)
May 6 2025, 12:49 PM
Unknown Object (File)
Apr 24 2025, 7:22 PM
Subscribers

Details

Summary

Refs T4195. Fixes T3936. You can't currently write rules like "block commits unless they're attached to an accepted revision"; allow that.

Test Plan

Pushed commits into a rule with this field, saw it work / not crash.

Diff Detail

Branch
hashq4
Lint
Lint Passed
Unit
No Test Coverage