Page MenuHomePhabricator

Add an "Accepted Differential revision" field to Commit and pre-commit Content Herald rules
ClosedPublic

Authored by epriestley on Dec 19 2013, 10:18 PM.
Tags
None
Referenced Files
F15513355: D7807.id.diff
Thu, Apr 17, 6:19 PM
F15418285: D7807.id17664.diff
Thu, Mar 20, 10:17 PM
F15412894: D7807.id17664.diff
Wed, Mar 19, 3:37 PM
F15396024: D7807.id17664.diff
Mar 16 2025, 11:18 AM
F15393186: D7807.id.diff
Mar 15 2025, 8:16 PM
F15388364: D7807.id17672.diff
Mar 15 2025, 3:43 AM
F15384739: D7807.id17664.diff
Mar 14 2025, 8:41 PM
Unknown Object (File)
Feb 9 2025, 10:55 AM
Subscribers

Details

Summary

Refs T4195. Fixes T3936. You can't currently write rules like "block commits unless they're attached to an accepted revision"; allow that.

Test Plan

Pushed commits into a rule with this field, saw it work / not crash.

Diff Detail

Branch
hashq4
Lint
Lint Passed
Unit
No Test Coverage