Page MenuHomePhabricator

Add an "Accepted Differential revision" field to Commit and pre-commit Content Herald rules
ClosedPublic

Authored by epriestley on Dec 19 2013, 10:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 3:35 AM
Unknown Object (File)
Mon, Dec 9, 3:07 PM
Unknown Object (File)
Mon, Dec 9, 11:19 AM
Unknown Object (File)
Sat, Nov 30, 7:30 AM
Unknown Object (File)
Sat, Nov 30, 7:30 AM
Unknown Object (File)
Sat, Nov 30, 6:56 AM
Unknown Object (File)
Sat, Nov 30, 6:32 AM
Unknown Object (File)
Nov 19 2024, 11:02 PM
Subscribers

Details

Summary

Refs T4195. Fixes T3936. You can't currently write rules like "block commits unless they're attached to an accepted revision"; allow that.

Test Plan

Pushed commits into a rule with this field, saw it work / not crash.

Diff Detail

Branch
hashq4
Lint
Lint Passed
Unit
No Test Coverage