Page MenuHomePhabricator

Reject dangerous changes in Git repositories by default
ClosedPublic

Authored by epriestley on Dec 3 2013, 4:24 PM.
Tags
None
Referenced Files
F14077367: D7689.diff
Thu, Nov 21, 10:56 PM
F14074454: D7689.diff
Thu, Nov 21, 6:45 AM
Unknown Object (File)
Sun, Nov 17, 12:27 AM
Unknown Object (File)
Fri, Nov 15, 9:32 AM
Unknown Object (File)
Fri, Nov 15, 9:32 AM
Unknown Object (File)
Fri, Nov 15, 9:32 AM
Unknown Object (File)
Fri, Nov 15, 9:32 AM
Unknown Object (File)
Fri, Nov 15, 9:32 AM
Tokens
"Piece of Eight" token, awarded by poop."The World Burns" token, awarded by bitglue."Mountain of Wealth" token, awarded by dctrwatson.

Details

Summary

Ref T4189. This adds a per-repository "dangerous changes" flag, which defaults to off. This flag must be enabled to do non-appending branch mutation (delete branches / rewrite history).

Test Plan

With flag on and off, performed various safe and dangerous pushes.

>>> orbital ~/repos/POEMS $ git push origin :blarp
remote: +---------------------------------------------------------------+
remote: |      * * * PUSH REJECTED BY EVIL DRAGON BUREAUCRATS * * *     |
remote: +---------------------------------------------------------------+
remote:             \
remote:              \                    ^    /^
remote:               \                  / \  // \
remote:                \   |\___/|      /   \//  .\
remote:                 \  /V  V  \__  /    //  | \ \           *----*
remote:                   /     /  \/_/    //   |  \  \          \   |
remote:                   @___@`    \/_   //    |   \   \         \/\ \
remote:                  0/0/|       \/_ //     |    \    \         \  \
remote:              0/0/0/0/|        \///      |     \     \       |  |
remote:           0/0/0/0/0/_|_ /   (  //       |      \     _\     |  /
remote:        0/0/0/0/0/0/`/,_ _ _/  ) ; -.    |    _ _\.-~       /   /
remote:                    ,-}        _      *-.|.-~-.           .~    ~
remote:   \     \__/        `/\      /                 ~-. _ .-~      /
remote:    \____(Oo)           *.   }            {                   /
remote:    (    (--)          .----~-.\        \-`                 .~
remote:    //__\\  \ DENIED!  ///.----..<        \             _ -~
remote:   //    \\               ///-._ _ _ _ _ _ _{^ - - - - ~
remote: 
remote: 
remote: DANGEROUS CHANGE: The change you're attempting to push deletes the branch 'blarp'.
remote: Dangerous change protection is enabled for this repository.
remote: Edit the repository configuration before making dangerous changes.
remote: 
To ssh://dweller@localhost/diffusion/POEMS/
 ! [remote rejected] blarp (pre-receive hook declined)
error: failed to push some refs to 'ssh://dweller@localhost/diffusion/POEMS/'

Diff Detail

Branch
githooks2
Lint
Lint Passed
Unit
Tests Passed