Allow null for token expiration date
ClosedPublic
Actions

Authored by avivey on Oct 31 2013, 12:18 AM.

Tags

None

Referenced Files

	F14482144: D7466.diff
	Mon, Dec 30, 7:36 AM

	Unknown Object (File)
	Sat, Dec 28, 3:02 PM

	Unknown Object (File)
	Sat, Dec 21, 5:23 PM

	Unknown Object (File)
	Fri, Dec 13, 4:52 PM

	Unknown Object (File)
	Fri, Dec 13, 7:38 AM

	Unknown Object (File)
	Fri, Dec 6, 9:35 PM

	Unknown Object (File)
	Fri, Dec 6, 1:24 AM

	Unknown Object (File)
	Nov 29 2024, 3:44 PM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP2250ee6aa6b8: Allow null for token expiration date

Summary

At least under GitHub, the token value is stored as "null", and not missing. And null > anything is false, so Phabricator thinks the token is expired or not there.

Test Plan

http://ph.vm/settings/panel/external/ before shows "No OAuth Access Token," and after it says "Active OAuth Token".

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Closed by commit rP2250ee6aa6b8 (authored by Aviv Eyal <aeyal@groupon.com>, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

provider/

PhabricatorAuthProviderOAuth.php

4 lines

Diff 16824

View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuth.php

Allow null for token expiration date ClosedPublicActions