Differential D7370

Move Project transaction storage to modern tables
ClosedPublic
Actions

Authored by epriestley on Oct 20 2013, 10:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 17, 5:10 AM

	Unknown Object (File)
	Thu, Apr 11, 7:28 AM

	Unknown Object (File)
	Wed, Apr 10, 10:04 PM

	Unknown Object (File)
	Mon, Apr 8, 5:17 PM

	Unknown Object (File)
	Fri, Apr 5, 7:04 AM

	Unknown Object (File)
	Fri, Mar 29, 11:34 AM

	Unknown Object (File)
	Fri, Mar 29, 11:34 AM

	Unknown Object (File)
	Fri, Mar 29, 11:34 AM

Subscribers

Details

Reviewers

btrahan
chad

Maniphest Tasks

T4010: Implement Custom Property Fields for Projects

Commits

Restricted Diffusion Commit
rP9b89e137cfe4: Move Project transaction storage to modern tables

Summary

Ref T4010. Projects have a weird proto-version of ApplicationTransactions which is very similar but not quite the same.

Move the storage to a modern format, but keep all the other code for now.

Test Plan

Migrated project transactions; edited projects.

Diff Detail

Branch

pxact2

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

Looks good. Just two inline comments / questions.

resources/sql/patches/20131020.pxactionmig.php
45–47	should this happen? (ie what legacy transactions aren't getting ported over?)
src/applications/feed/constants/PhabricatorFeedStoryTypeConstants.php
6–10	what's going on here? surprised to see the status, differential, maniphest as part of his but maybe they all set now from other diffs?

epriestley added inline comments.Oct 22 2013, 8:42 PM

resources/sql/patches/20131020.pxactionmig.php
45–47	It shouldn't, but it's possible that there's some very very old stuff that's no longer present in the codebase, since I think this table is pretty oldschool. I just don't want to bring any dirty data forward if it does exist.
src/applications/feed/constants/PhabricatorFeedStoryTypeConstants.php
6–10	A few things: Maniphest and Project use ApplicationTransactions feed stories now, so they don't need their own classes. Differential uses the raw class name or something; it will switch to ApplicationTransactions after T2222. We should move away from stuff like this in general since third party applications can't add it. "Statuses" were deleted like two years ago, this just never got cleaned up.

Closed by commit rP9b89e137cfe4 (authored by @epriestley).

joshuaspence mentioned this in D11129: Remove an unused class.Jan 1 2015, 11:13 PM

joshuaspence mentioned this in D11132: Remove an unused feed story class.Jan 1 2015, 11:37 PM

joshuaspence mentioned this in rPcfadc4145900: Remove an unused class.Jan 2 2015, 12:36 AM

joshuaspence mentioned this in rPf1d343111f30: Remove an unused feed story class.Jan 2 2015, 12:51 AM

Revision Contents
Changeset List

Path

Size

resources/

sql/

patches/

20131020.pxaction.sql

24 lines

20131020.pxactionmig.php

92 lines

src/

__phutil_library_map__.php

12 lines

applications/

feed/

constants/

PhabricatorFeedStoryTypeConstants.php

4 lines

story/

PhabricatorFeedStoryProject.php

project/

constants/

PhabricatorProjectTransactionType.php

controller/

PhabricatorProjectCreateController.php

4 lines

PhabricatorProjectMembersEditController.php

2 lines

PhabricatorProjectProfileEditController.php

10 lines

editor/

PhabricatorProjectEditor.php

70 lines

__tests__/

PhabricatorProjectEditorTestCase.php

2 lines

lipsum/

PhabricatorProjectTestDataGenerator.php

12 lines

storage/

PhabricatorProjectTransaction.php

27 lines

transactions/

constants/

PhabricatorTransactions.php

1 line

infrastructure/

storage/

patch/

PhabricatorBuiltinPatchList.php

8 lines

Diff 16587

resources/sql/patches/20131020.pxaction.sql

Loading...

resources/sql/patches/20131020.pxactionmig.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/feed/constants/PhabricatorFeedStoryTypeConstants.php

Loading...

src/applications/feed/story/PhabricatorFeedStoryProject.php

Loading...

src/applications/project/constants/PhabricatorProjectTransactionType.php

Loading...

src/applications/project/controller/PhabricatorProjectCreateController.php

Loading...

src/applications/project/controller/PhabricatorProjectMembersEditController.php

Loading...

src/applications/project/controller/PhabricatorProjectProfileEditController.php

Loading...

src/applications/project/editor/PhabricatorProjectEditor.php

Loading...

src/applications/project/editor/tests/PhabricatorProjectEditorTestCase.php

Loading...

src/applications/project/lipsum/PhabricatorProjectTestDataGenerator.php

Loading...

src/applications/project/storage/PhabricatorProjectTransaction.php

Loading...

src/applications/transactions/constants/PhabricatorTransactions.php

Loading...

src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php

Loading...