Page MenuHomePhabricator

Move Project transaction storage to modern tables
ClosedPublic

Authored by epriestley on Oct 20 2013, 10:26 PM.

Details

Summary

Ref T4010. Projects have a weird proto-version of ApplicationTransactions which is very similar but not quite the same.

Move the storage to a modern format, but keep all the other code for now.

Test Plan

Migrated project transactions; edited projects.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Looks good. Just two inline comments / questions.

resources/sql/patches/20131020.pxactionmig.php
45–47

should this happen? (ie what legacy transactions aren't getting ported over?)

src/applications/feed/constants/PhabricatorFeedStoryTypeConstants.php
6–10

what's going on here? surprised to see the status, differential, maniphest as part of his but maybe they all set now from other diffs?

resources/sql/patches/20131020.pxactionmig.php
45–47

It shouldn't, but it's possible that there's some very very old stuff that's no longer present in the codebase, since I think this table is pretty oldschool. I just don't want to bring any dirty data forward if it does exist.

src/applications/feed/constants/PhabricatorFeedStoryTypeConstants.php
6–10

A few things:

  1. Maniphest and Project use ApplicationTransactions feed stories now, so they don't need their own classes.
  2. Differential uses the raw class name or something; it will switch to ApplicationTransactions after T2222.
  3. We should move away from stuff like this in general since third party applications can't add it.
  4. "Statuses" were deleted like two years ago, this just never got cleaned up.