Allow to push revisions to review by himself to Differential (bug T1879, change 2/2, Arcanist part)
ClosedPublic
Actions

Authored by dereckson on Oct 10 2012, 2:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 5, 9:31 PM

	Unknown Object (File)
	Thu, Oct 1, 12:41 PM

	Unknown Object (File)
	Aug 16 2026, 5:49 AM

	Unknown Object (File)
	Mar 11 2026, 9:24 AM

	Unknown Object (File)
	Mar 9 2026, 4:04 PM

	Unknown Object (File)
	Mar 6 2026, 1:13 PM

	Unknown Object (File)
	Mar 5 2026, 9:39 AM

	Unknown Object (File)
	Mar 3 2026, 10:27 PM

View All Files

Subscribers

aran

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit

Summary

The 'review its own revision' check is now handled by Differential (bug T1879)

Previous behavior:

arc threw an "You can not be a reviewer for your own revision." exception
if an users adds itself as reviewer, even when this configuration is
allowed on the Differential remote install's configuration.

New behavior:

Arc doesn't check that anymore. It still will be checked by the server.

Test Plan

Tested locally pushing revisions with "arc diff" to a Phabricator server with differential.allow-self-accept at true or false with myself or not as reviewer.

Diff Detail

Branch

bug/T1879

Lint

Lint Skipped

Unit

No Test Coverage

Event Timeline

Awesome, thanks!

Closed by commit rARC5725585f2dc7 (authored by @dereckson, committed by @epriestley).

dereckson edited edge metadata.Mar 12 2016, 6:26 AM

dereckson changed the visibility from "All Users" to "Public (No Login Required)".

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

3 lines

Diff 7307

View Options

src/workflow/ArcanistDiffWorkflow.php

Allow to push revisions to review by himself to Differential (bug T1879, change 2/2, Arcanist part)ClosedPublicActions