Allow to push revisions to review by himself to Differential (bug T1879, change 2/2, Arcanist part)
ClosedPublic
Actions

Authored by dereckson on Oct 10 2012, 2:41 PM.

Tags

None

Referenced Files

	F15490970: D3674.id7307.diff
	Fri, Apr 11, 10:08 PM

	F15490175: D3674.id7307.diff
	Fri, Apr 11, 2:59 PM

	F15477643: D3674.id7333.diff
	Mon, Apr 7, 4:59 PM

	F15475370: D3674.id.diff
	Sun, Apr 6, 7:18 PM

	F15472102: D3674.diff
	Sat, Apr 5, 10:55 AM

	F15458516: D3674.id7333.diff
	Mon, Mar 31, 4:13 AM

	F15395704: D3674.id7307.diff
	Mar 16 2025, 9:05 AM

	F15389997: D3674.diff
	Mar 15 2025, 5:49 AM

View All Files

Subscribers

aran

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

Restricted Maniphest Task

Commits

rARC5725585f2dc7: Allow to push revisions to review by himself to Differential (bug T1879, change…

Summary

The 'review its own revision' check is now handled by Differential (bug T1879)

Previous behavior:

arc threw an "You can not be a reviewer for your own revision." exception
if an users adds itself as reviewer, even when this configuration is
allowed on the Differential remote install's configuration.

New behavior:

Arc doesn't check that anymore. It still will be checked by the server.

Test Plan

Tested locally pushing revisions with "arc diff" to a Phabricator server with differential.allow-self-accept at true or false with myself or not as reviewer.

Diff Detail

Branch

bug/T1879

Lint

Lint Skipped

Unit

No Test Coverage

Event Timeline

Awesome, thanks!

Closed by commit rARC5725585f2dc7 (authored by @dereckson, committed by @epriestley).

dereckson edited edge metadata.Mar 12 2016, 6:26 AM

dereckson changed the visibility from "All Users" to "Public (No Login Required)".

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

3 lines

Diff 7307

View Options

src/workflow/ArcanistDiffWorkflow.php

Allow to push revisions to review by himself to Differential (bug T1879, change 2/2, Arcanist part)ClosedPublicActions