Page MenuHomePhabricator

Allow to push revisions to review by himself to Differential (bug T1879, change 2/2, Arcanist part)
ClosedPublic

Authored by dereckson on Oct 10 2012, 2:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 11 2026, 9:24 AM
Unknown Object (File)
Mar 9 2026, 4:04 PM
Unknown Object (File)
Mar 6 2026, 1:13 PM
Unknown Object (File)
Mar 5 2026, 9:39 AM
Unknown Object (File)
Mar 3 2026, 10:27 PM
Unknown Object (File)
Jan 31 2026, 1:37 PM
Unknown Object (File)
Jan 19 2026, 12:01 PM
Unknown Object (File)
Jan 19 2026, 11:44 AM
Subscribers

Details

Summary

The 'review its own revision' check is now handled by Differential (bug T1879)

Previous behavior:

arc threw an "You can not be a reviewer for your own revision." exception
if an users adds itself as reviewer, even when this configuration is
allowed on the Differential remote install's configuration.

New behavior:

Arc doesn't check that anymore. It still will be checked by the server.
Test Plan

Tested locally pushing revisions with "arc diff" to a Phabricator server with differential.allow-self-accept at true or false with myself or not as reviewer.

Diff Detail

Branch
bug/T1879
Lint
Lint Skipped
Unit
No Test Coverage

Event Timeline

dereckson changed the visibility from "All Users" to "Public (No Login Required)".