Page MenuHomePhabricator

Allow to push revisions to review by himself to Differential (bug T1879, change 1/2, Differential part)
ClosedPublic

Authored by dereckson on Oct 10 2012, 2:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 10:12 AM
Unknown Object (File)
Sun, Feb 9, 10:12 AM
Unknown Object (File)
Sun, Feb 9, 10:12 AM
Unknown Object (File)
Fri, Feb 7, 3:04 AM
Unknown Object (File)
Thu, Feb 6, 9:31 PM
Unknown Object (File)
Thu, Feb 6, 6:55 PM
Unknown Object (File)
Tue, Feb 4, 5:56 PM
Unknown Object (File)
Tue, Jan 28, 1:36 AM
Subscribers

Details

Reviewers
epriestley
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPb7b783d77125: Allow to push revisions to review by himself to Differential (bug T1879, change…
Summary

Checks if the revision author is in reviewers only if differential.allow-self-accept is false.

Test Plan

Tested locally pushing revisions with "arc diff" to a Phabricator
server with differential.allow-self-accept at true or false with
myself or not as reviewer.

Diff Detail

Branch
bug/T1879
Lint
Lint Skipped
Unit
Tests Passed

Event Timeline

Thanks! Either send me a pull request on GitHub or give me a public email address that I can use for author credit and I'll pull from here.

To be coherent with commit rARC088091ca4094, the best would maybe to use:
Author: Sébastien Santoro <dereckson@espace-win.org>

If coherence in commits history isn't a requirement, you can also keep the current commit information (which should be Author: Dereckson <dereckson@espace-win.org>).

dereckson changed the visibility from "All Users" to "Public (No Login Required)".