Page MenuHomePhabricator

Addressing PHP8 incompatibilities - Diffusion, Drydock, Harbormastor
Needs ReviewPublic

Authored by cspeckmim on Jun 5 2023, 1:11 PM.
Tags
None
Referenced Files
F13483071: D21873.diff
Sat, Jul 20, 6:21 AM
F13480773: D21873.diff
Fri, Jul 19, 9:01 AM
F13456752: D21873.id52179.diff
Sun, Jul 14, 3:22 PM
F13451992: D21873.id.diff
Sat, Jul 13, 3:56 PM
F13409350: D21873.diff
Sat, Jul 6, 9:30 AM
F13405425: D21873.diff
Fri, Jul 5, 3:13 PM
F13386933: D21873.id.diff
Mon, Jul 1, 6:07 AM
F13386135: D21873.id52179.diff
Mon, Jul 1, 4:34 AM
Subscribers
Restricted Owners Package

Details

Reviewers
None
Group Reviewers
Blessed Reviewers
Summary

Fixing a few more null-string issues.

Test Plan
  • I used the search icon next to a Repository field to list and locate diffusion repositories
  • I modified a repository's default branch name to something, something else, empty, something else - and verified the history page for the repository displayed properly
  • I modified a repository's staging area and view the history of the repository verified the history page displayed properly
  • I created and edited several Almanac resources (all the available different types), and several Drydock Blueprints, one for Almanac Host and one for Working Copy
  • Visited all the UIExample views

Diff Detail

Repository
rP Phabricator
Branch
cspeck-php8-misc
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25835
Build 35663: arc lint + arc unit

Event Timeline

cspeckmim held this revision as a draft.
Owners added a subscriber: Restricted Owners Package.Jun 5 2023, 1:11 PM
cspeckmim retitled this revision from Addressing PHP8 incompatibilities - Miscellaneous to Addressing PHP8 incompatibilities - Diffusion, Drydock, Harbormastor.Jun 6 2023, 1:45 AM
cspeckmim edited the test plan for this revision. (Show Details)

Found a few things while running through tests. Revert change to DifferentialAuditorsField as it doesn't appear to be necessary (anymore?).

Found two more quick issues

  • Adding search results to dashboard hit an error
  • Viewing the prototype calendar event failed after creating an event