Paths

Table of Contentst

Differential D21870

Address some PHP8 incompatibilities - Arcanist
ClosedPublic
Actions

Authored by cspeckmim on May 29 2023, 11:40 PM.

Tags

None

Referenced Files

	F15856726: D21870.id.diff
	Sat, May 31, 6:06 AM

	Unknown Object (File)
	Fri, May 30, 5:45 AM

	Unknown Object (File)
	Thu, May 29, 6:14 AM

	Unknown Object (File)
	Wed, May 28, 7:10 PM

	Unknown Object (File)
	Fri, May 9, 11:45 PM

	Unknown Object (File)
	Apr 28 2025, 10:55 AM

	Unknown Object (File)
	Apr 24 2025, 5:23 AM

	Unknown Object (File)
	Apr 23 2025, 6:54 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T13588: PHP 8 Compatibility

Commits

rARCe50d1bc4eaba: Address some PHP8 incompatibilities - Arcanist

Summary

Found a few more issues while playing around with arc.

Test Plan

Run arc look and variants with subcommands
Run arc diff while not on a git branch

Diff Detail

Repository

Branch

cspeck-php8-arc

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 25831
Build 35659: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	2,834 ms	ArcanistCoffeeLintLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "no_trailing_whitespace.lint-test". MISSING MESSAGES Message with severity "error" at "1:0"
	189 ms	ArcanistCppcheckLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "zblair.lint-test". MISSING MESSAGES Message with severity "error" at "10:<null>"
	1,575 ms	ArcanistJSHintLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "too-many-errors.lint-test". MISSING MESSAGES Message with severity "disabled" at "2:22" (E043)
	917 ms	ArcanistJscsLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "curly-brace.lint-test". MISSING MESSAGES Message with severity "error" at "2:3"
	1,385 ms	ArcanistLesscLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "javascript.lint-test". MISSING MESSAGES (No messages.)
		View Full Test Results (8 Failed · 41 Passed · 8 Skipped)

Event Timeline

cspeckmim created this revision.May 29 2023, 11:40 PM

cspeckmim held this revision as a draft.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 29 2023, 11:40 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B25825: Diff 52166.May 29 2023, 11:40 PM

Update version check for Cppcheck to include optional bugfix version

Harbormaster completed remote builds in B25831: Diff 52172.May 30 2023, 3:22 PM

cspeckmim edited the summary of this revision. (Show Details)May 30 2023, 3:34 PM

cspeckmim added a task: T13588: PHP 8 Compatibility.

Looking at the rest of the UT failures I think those are due to updated/newer versions of linters emitting slightly different results.

epriestley accepted this revision.May 30 2023, 4:29 PM

This revision is now accepted and ready to land.May 30 2023, 4:29 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 30 2023, 4:29 PM

This revision was landed with ongoing or failed builds.May 30 2023, 4:39 PM

Closed by commit rARCe50d1bc4eaba: Address some PHP8 incompatibilities - Arcanist (authored by cspeckmim). · Explain Why

This revision was automatically updated to reflect the committed changes.

cspeckmim added a commit: rARCe50d1bc4eaba: Address some PHP8 incompatibilities - Arcanist.

Revision Contents
Changeset List

Path

Size

src/

browse/

query/

ArcanistBrowseObjectNameURIHardpointQuery.php

2 lines

lint/

linter/

ArcanistCppcheckLinter.php

2 lines

ArcanistScriptAndRegexLinter.php

10 lines

ref/

ArcanistRefView.php

10 lines

repository/

api/

ArcanistGitAPI.php

2 lines

workflow/

ArcanistWorkflow.php

4 lines

Diff 52172

src/browse/query/ArcanistBrowseObjectNameURIHardpointQuery.php

Loading...

src/lint/linter/ArcanistCppcheckLinter.php

Loading...

src/lint/linter/ArcanistScriptAndRegexLinter.php

Loading...

src/ref/ArcanistRefView.php

Loading...

src/repository/api/ArcanistGitAPI.php

Loading...

src/workflow/ArcanistWorkflow.php

Loading...