Page MenuHomePhabricator

Address some PHP8 incompatibilities - Arcanist
ClosedPublic

Authored by cspeckmim on May 29 2023, 11:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 9:59 AM
Unknown Object (File)
Fri, May 3, 10:14 PM
Unknown Object (File)
Sun, Apr 28, 6:57 PM
Unknown Object (File)
Sun, Apr 28, 10:58 AM
Unknown Object (File)
Thu, Apr 25, 1:44 AM
Unknown Object (File)
Sat, Apr 20, 1:22 PM
Unknown Object (File)
Fri, Apr 19, 5:20 AM
Unknown Object (File)
Fri, Apr 19, 3:24 AM
Subscribers

Details

Summary

Found a few more issues while playing around with arc.

Refs T13588

Test Plan
  • Run arc look and variants with subcommands
  • Run arc diff while not on a git branch

Diff Detail

Repository
rARC Arcanist
Branch
cspeck-php8-arc
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25831
Build 35659: arc lint + arc unit

Unit TestsFailed

TimeTest
2,834 msArcanistCoffeeLintLinterTestCase::testLinter
Lint emitted an unexpected set of messages for file "no_trailing_whitespace.lint-test". MISSING MESSAGES Message with severity "error" at "1:0"
189 msArcanistCppcheckLinterTestCase::testLinter
Lint emitted an unexpected set of messages for file "zblair.lint-test". MISSING MESSAGES Message with severity "error" at "10:<null>"
1,575 msArcanistJSHintLinterTestCase::testLinter
Lint emitted an unexpected set of messages for file "too-many-errors.lint-test". MISSING MESSAGES Message with severity "disabled" at "2:22" (E043)
917 msArcanistJscsLinterTestCase::testLinter
Lint emitted an unexpected set of messages for file "curly-brace.lint-test". MISSING MESSAGES Message with severity "error" at "2:3"
1,385 msArcanistLesscLinterTestCase::testLinter
Lint emitted an unexpected set of messages for file "javascript.lint-test". MISSING MESSAGES (No messages.)
View Full Test Results (8 Failed · 41 Passed · 8 Skipped)

Event Timeline

cspeckmim held this revision as a draft.

Update version check for Cppcheck to include optional bugfix version

Looking at the rest of the UT failures I think those are due to updated/newer versions of linters emitting slightly different results.

This revision is now accepted and ready to land.May 30 2023, 4:29 PM
This revision was landed with ongoing or failed builds.May 30 2023, 4:39 PM
This revision was automatically updated to reflect the committed changes.