Paths

Table of Contentst

Differential D21870

Address some PHP8 incompatibilities - Arcanist
ClosedPublic
Actions

Authored by cspeckmim on May 29 2023, 11:40 PM.

Tags

None

Referenced Files

	F15555338: D21870.id52172.diff
	Mon, Apr 28, 10:55 AM

	F15535481: D21870.id52172.diff
	Thu, Apr 24, 5:23 AM

	F15533244: D21870.id52166.diff
	Wed, Apr 23, 6:54 PM

	F15524962: D21870.id52166.diff
	Mon, Apr 21, 11:27 AM

	F15489819: D21870.diff
	Fri, Apr 11, 12:34 PM

	F15489599: D21870.id52177.diff
	Fri, Apr 11, 10:33 AM

	F15486254: D21870.id.diff
	Thu, Apr 10, 6:04 AM

	F15483562: D21870.diff
	Apr 9 2025, 1:04 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T13588: PHP 8 Compatibility

Commits

rARCe50d1bc4eaba: Address some PHP8 incompatibilities - Arcanist

Summary

Found a few more issues while playing around with arc.

Test Plan

Run arc look and variants with subcommands
Run arc diff while not on a git branch

Diff Detail

Repository

Branch

cspeck-php8-arc

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 25825
Build 35653: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,501 ms	ArcanistJSHintLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "too-many-errors.lint-test". MISSING MESSAGES Message with severity "disabled" at "2:22" (E043)
	34 ms	ArcanistXMLLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "languages-6.lint-test". MISSING MESSAGES Message with severity "error" at "3:16" (XML76)
	20 ms	ArcanistChmodLinterTestCase::testLinter 5 assertion(s) passed.
	0 ms	ArcanistClosureLinterTestCase::testVersion 1 assertion(s) passed.
	0 ms	ArcanistCpplintLinterTestCase::testVersion 1 assertion(s) passed.
		View Full Test Results (2 Failed · 26 Passed · 29 Skipped)

Event Timeline

cspeckmim created this revision.May 29 2023, 11:40 PM

cspeckmim held this revision as a draft.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 29 2023, 11:40 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B25825: Diff 52166.May 29 2023, 11:40 PM

Update version check for Cppcheck to include optional bugfix version

Harbormaster completed remote builds in B25831: Diff 52172.May 30 2023, 3:22 PM

cspeckmim edited the summary of this revision. (Show Details)May 30 2023, 3:34 PM

cspeckmim added a task: T13588: PHP 8 Compatibility.

Looking at the rest of the UT failures I think those are due to updated/newer versions of linters emitting slightly different results.

epriestley accepted this revision.May 30 2023, 4:29 PM

This revision is now accepted and ready to land.May 30 2023, 4:29 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 30 2023, 4:29 PM

This revision was landed with ongoing or failed builds.May 30 2023, 4:39 PM

Closed by commit rARCe50d1bc4eaba: Address some PHP8 incompatibilities - Arcanist (authored by cspeckmim). · Explain Why

This revision was automatically updated to reflect the committed changes.

cspeckmim added a commit: rARCe50d1bc4eaba: Address some PHP8 incompatibilities - Arcanist.

Revision Contents
Changeset List

Path

Size

src/

browse/

query/

ArcanistBrowseObjectNameURIHardpointQuery.php

2 lines

lint/

linter/

ArcanistScriptAndRegexLinter.php

10 lines

ref/

ArcanistRefView.php

10 lines

repository/

api/

ArcanistGitAPI.php

2 lines

workflow/

ArcanistWorkflow.php

4 lines

Diff 52166

src/browse/query/ArcanistBrowseObjectNameURIHardpointQuery.php

Loading...

src/lint/linter/ArcanistScriptAndRegexLinter.php

Loading...

src/ref/ArcanistRefView.php

Loading...

src/repository/api/ArcanistGitAPI.php

Loading...

src/workflow/ArcanistWorkflow.php

Loading...