Page MenuHomePhabricator

Update Figlet implementation to be PHP8 compatible
ClosedPublic

Authored by cspeckmim on Apr 25 2023, 2:53 PM.
Tags
None
Referenced Files
F13238705: D21860.diff
Tue, May 21, 8:50 PM
F13217215: D21860.diff
Sat, May 18, 4:00 AM
F13213941: D21860.diff
Fri, May 17, 8:16 AM
F13198353: D21860.diff
Mon, May 13, 5:54 AM
F13182935: D21860.diff
Fri, May 10, 5:16 AM
Unknown Object (File)
Sat, May 4, 10:20 AM
Unknown Object (File)
Tue, Apr 30, 11:55 PM
Unknown Object (File)
Sun, Apr 28, 12:38 PM
Subscribers

Details

Summary

As of PHP ~v8 the zip_open and associated functions have been deprecated and
removed. The replacement is the ZipArchive API. This updates the figlet
implementation to use this API which has been present in PHP since 5.2.

Additionally in PHP 8 the use of squiggly brackets for indexing into arrays is
also deprecated. This updates to remove two uses of squiggly brackets and
replace with square brackets.

These two deprecations would result in being unable to load differential
revisions in which someone had commented using figlet remarkup.

Refs T13588

Test Plan

Applied these changes to an install and loaded a revision that had comments
where someone utilized figlet remarkup. The revision loaded properly and the
figlet comment rendered properly.

Diff Detail

Repository
rP Phabricator
Branch
cspeck-php8-figlet
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 25772
Build 35600: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 25 2023, 2:59 PM

(It would also probably be fine to just remove support for compressed figlet fonts, they're probably saving like 5KB?)

Oh whoops. I didn't realize figlet font file format wasn't compressed