Paths

Table of Contentst

Differential D21860

Update Figlet implementation to be PHP8 compatible
ClosedPublic
Actions

Authored by cspeckmim on Apr 25 2023, 2:53 PM.

Tags

None

Referenced Files

	F13037842: D21860.diff
	Mon, Apr 15, 8:06 PM

	F13037684: D21860.diff
	Mon, Apr 15, 5:07 PM

	Unknown Object (File)
	Thu, Apr 11, 10:37 AM

	Unknown Object (File)
	Thu, Apr 11, 4:31 AM

	Unknown Object (File)
	Mon, Apr 8, 6:17 PM

	Unknown Object (File)
	Sun, Apr 7, 3:48 PM

	Unknown Object (File)
	Sat, Mar 30, 10:32 AM

	Unknown Object (File)
	Sat, Mar 30, 10:32 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T13588: PHP 8 Compatibility

Commits

rPd5c63c86e7e4: Update Figlet implementation to be PHP8 compatible

Summary

As of PHP ~v8 the zip_open and associated functions have been deprecated and
removed. The replacement is the ZipArchive API. This updates the figlet
implementation to use this API which has been present in PHP since 5.2.

Additionally in PHP 8 the use of squiggly brackets for indexing into arrays is
also deprecated. This updates to remove two uses of squiggly brackets and
replace with square brackets.

These two deprecations would result in being unable to load differential
revisions in which someone had commented using figlet remarkup.

Test Plan

Applied these changes to an install and loaded a revision that had comments
where someone utilized figlet remarkup. The revision loaded properly and the
figlet comment rendered properly.

Diff Detail

Repository

Branch

cspeck-php8-figlet

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 25772
Build 35600: arc lint + arc unit

Event Timeline

cspeckmim created this revision.Apr 25 2023, 2:53 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 25 2023, 2:53 PM

Harbormaster completed remote builds in B25772: Diff 52104.Apr 25 2023, 2:53 PM

cspeckmim requested review of this revision.Apr 25 2023, 2:53 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 25 2023, 2:53 PM

Thanks!

This revision is now accepted and ready to land.Apr 25 2023, 2:59 PM

Closed by commit rPd5c63c86e7e4: Update Figlet implementation to be PHP8 compatible (authored by cspeckmim). · Explain WhyApr 25 2023, 3:03 PM

This revision was automatically updated to reflect the committed changes.

cspeckmim added a commit: rPd5c63c86e7e4: Update Figlet implementation to be PHP8 compatible.

(It would also probably be fine to just remove support for compressed figlet fonts, they're probably saving like 5KB?)

Oh whoops. I didn't realize figlet font file format wasn't compressed

cspeckmim mentioned this in D21861: Fix support for pk-zip compressed figlet font files.Apr 25 2023, 3:35 PM

cspeckmim mentioned this in rPbc6f4786a2e3: Fix support for pk-zip compressed figlet font files.Apr 25 2023, 8:30 PM

cspeckmim mentioned this in D21866: Addressing some PHP 8 incompatibilities - Remarkup.May 25 2023, 12:09 AM

cspeckmim mentioned this in rPec9ebe532e52: Addressing some PHP 8 incompatibilities - Remarkup.May 29 2023, 3:12 AM

Revision Contents
Changeset List

Path

Size

externals/

pear-figlet/

Text/

25 lines

Diff 52104

externals/pear-figlet/Text/Figlet.php

Loading...