Page MenuHomePhabricator
Differential D21856

Correct a PHP8 compatibility issue when running "arc diff" with no active branch
ClosedPublic
Actions

Authored by epriestley on Feb 4 2023, 1:03 PM.
Tags
None
Referenced Files
F14082420: D21856.id52093.diff
Fri, Nov 22, 11:45 PM
Unknown Object (File)
Thu, Nov 21, 9:27 PM
Unknown Object (File)
Thu, Nov 21, 4:11 PM
Unknown Object (File)
Thu, Nov 14, 9:14 PM
Unknown Object (File)
Oct 23 2024, 9:21 AM
Unknown Object (File)
Oct 23 2024, 8:11 AM
Unknown Object (File)
Oct 23 2024, 7:29 AM
Unknown Object (File)
Oct 22 2024, 9:46 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13588: PHP 8 Compatibility
Commits
rARCc39ab20eb371: Correct a PHP8 compatibility issue when running "arc diff" with no active branch
Summary

Ref T13588. See PHI2228. When there is no active branch name (for example, because you are in Git on a detached HEAD), this section currently fails under PHP8 when we try to strlen(null).

Test Plan

Under PHP 8.1: ran git checkout <hash of head>, then arc diff to generate this revision.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley requested review of this revision.Feb 4 2023, 1:03 PM
epriestley created this revision.
Harbormaster completed remote builds in B25765: Diff 52092.Feb 4 2023, 1:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2023, 1:16 PM
Closed by commit rARCc39ab20eb371: Correct a PHP8 compatibility issue when running "arc diff" with no active branch (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCc39ab20eb371: Correct a PHP8 compatibility issue when running "arc diff" with no active branch.

Revision Contents
Changeset List

PathSize
src/
workflow/
2 lines

Diff 52093

View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
Phabricator · Built by Phacility