Page MenuHomePhabricator

Correct a PHP8 compatibility issue when running "arc diff" with no active branch
ClosedPublic

Authored by epriestley on Feb 4 2023, 1:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 28, 11:03 PM
Unknown Object (File)
Sun, May 28, 11:03 PM
Unknown Object (File)
Sun, May 28, 11:03 PM
Unknown Object (File)
Tue, May 23, 9:13 AM
Unknown Object (File)
Sun, May 14, 7:07 PM
Unknown Object (File)
Sat, May 13, 12:38 PM
Unknown Object (File)
Sat, May 13, 12:38 PM
Unknown Object (File)
Sat, May 13, 12:38 PM
Subscribers
None

Details

Summary

Ref T13588. See PHI2228. When there is no active branch name (for example, because you are in Git on a detached HEAD), this section currently fails under PHP8 when we try to strlen(null).

Test Plan

Under PHP 8.1: ran git checkout <hash of head>, then arc diff to generate this revision.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2023, 1:16 PM
This revision was automatically updated to reflect the committed changes.