Correct a PHP8 compatibility issue when running "arc diff" with no active branch
ClosedPublic
Actions

Authored by epriestley on Feb 4 2023, 1:03 PM.

Tags

None

Referenced Files

	F18349151: D21856.diff
	Tue, Aug 26, 5:57 PM

	F18348254: D21856.diff
	Tue, Aug 26, 4:29 PM

	F18343645: D21856.diff
	Tue, Aug 26, 8:19 AM

	F18336922: D21856.diff
	Mon, Aug 25, 5:20 PM

	F18259971: D21856.diff
	Fri, Aug 22, 4:42 AM

	F18213089: D21856.id.diff
	Tue, Aug 19, 4:27 AM

	F18208482: D21856.id52092.diff
	Mon, Aug 18, 9:10 PM

	F18207911: D21856.diff
	Mon, Aug 18, 7:37 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rARCc39ab20eb371: Correct a PHP8 compatibility issue when running "arc diff" with no active branch

Summary

Ref T13588. See PHI2228. When there is no active branch name (for example, because you are in Git on a detached HEAD), this section currently fails under PHP8 when we try to strlen(null).

Test Plan

Under PHP 8.1: ran git checkout <hash of head>, then arc diff to generate this revision.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25765
Build 35593: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.Feb 4 2023, 1:03 PM

epriestley created this revision.

Harbormaster completed remote builds in B25765: Diff 52092.Feb 4 2023, 1:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2023, 1:16 PM

Closed by commit rARCc39ab20eb371: Correct a PHP8 compatibility issue when running "arc diff" with no active branch (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCc39ab20eb371: Correct a PHP8 compatibility issue when running "arc diff" with no active branch.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

2 lines

Diff 52092

View Options

src/workflow/ArcanistDiffWorkflow.php

Correct a PHP8 compatibility issue when running "arc diff" with no active branchClosedPublicActions