Page MenuHomePhabricator

Remove the "25% of active pool" growth rate throttle from Drydock
ClosedPublic

Authored by epriestley on May 9 2022, 5:30 PM.
Tags
None
Referenced Files
F13466905: D21808.diff
Tue, Jul 16, 7:48 PM
F13463512: D21808.diff
Mon, Jul 15, 3:43 PM
F13455057: D21808.diff
Sun, Jul 14, 8:24 AM
F13431977: D21808.diff
Wed, Jul 10, 9:33 AM
F13428562: D21808.id51982.diff
Tue, Jul 9, 10:55 PM
F13385797: D21808.id51982.diff
Mon, Jul 1, 2:53 AM
F13341363: D21808.id51978.diff
Thu, Jun 20, 6:31 AM
F13339369: D21808.diff
Wed, Jun 19, 5:06 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13677. Drydock has a hard-coded and fairly arbitrary limit which prevents a resource pool from growing more than 25% at once.

This is vaguely reasonable for resources which allocate quickly, but suffocating for slower resources. It's also wholly arbitrary, and the "one per lease" limit introduced in D21807 should do a better job of covering the same ground while generally being more reasonable, expected, and predictable.

Test Plan

Ran Drydock allocations without the throttle, saw faster pool growth.

Diff Detail

Repository
rP Phabricator
Branch
drydock-4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25705
Build 35533: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 9 2022, 5:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 9 2022, 5:40 PM
This revision was automatically updated to reflect the committed changes.