Page MenuHomePhabricator

Remove the "25% of active pool" growth rate throttle from Drydock

Authored by epriestley on May 9 2022, 5:30 PM.
Referenced Files
F13317772: D21808.diff
Thu, Jun 13, 9:53 AM
F13314960: D21808.id51982.diff
Wed, Jun 12, 6:42 AM
F13303446: D21808.diff
Sat, Jun 8, 6:45 AM
F13287051: D21808.diff
Tue, Jun 4, 8:11 AM
F13273437: D21808.diff
Fri, May 31, 1:55 AM
F13270315: D21808.id51982.diff
Wed, May 29, 9:29 AM
F13270314: D21808.id51978.diff
Wed, May 29, 9:29 AM
Wed, May 29, 9:29 AM
Restricted Owners Package



Ref T13677. Drydock has a hard-coded and fairly arbitrary limit which prevents a resource pool from growing more than 25% at once.

This is vaguely reasonable for resources which allocate quickly, but suffocating for slower resources. It's also wholly arbitrary, and the "one per lease" limit introduced in D21807 should do a better job of covering the same ground while generally being more reasonable, expected, and predictable.

Test Plan

Ran Drydock allocations without the throttle, saw faster pool growth.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 9 2022, 5:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 9 2022, 5:40 PM
This revision was automatically updated to reflect the committed changes.