Page MenuHomePhabricator

Modularize individual Harbormaster build messages
ClosedPublic

Authored by epriestley on Jul 15 2021, 10:24 PM.
Tags
None
Referenced Files
F18777047: D21690.id51703.diff
Sat, Oct 11, 12:44 AM
F18740327: D21690.id51703.diff
Thu, Oct 2, 2:08 AM
F18734431: D21690.id.diff
Tue, Sep 30, 10:54 PM
F18696078: D21690.id.diff
Sat, Sep 27, 6:59 AM
F18646044: D21690.id51652.diff
Fri, Sep 19, 9:12 AM
F18589991: D21690.diff
Sep 12 2025, 4:50 AM
F18588995: D21690.id.diff
Sep 12 2025, 2:06 AM
F18585651: D21690.diff
Sep 11 2025, 3:57 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. Further modularize build messages by applying each one in a separate transaction type.

This makes it easier to add new types of messages (although I have no particular plans to do this, offhand) and reduces the amount of switch-boilerplate.

This will probably also simplify validating "harbormaster.sendmessage".

Test Plan
  • Applied all commands.
  • Ran migration, saw transactions render properly

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 15 2021, 10:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:17 PM
This revision was automatically updated to reflect the committed changes.