Page MenuHomePhabricator

Modularize individual Harbormaster build messages
ClosedPublic

Authored by epriestley on Jul 15 2021, 10:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 28, 10:04 PM
Unknown Object (File)
Sat, May 13, 11:59 AM
Unknown Object (File)
Wed, May 3, 6:48 PM
Unknown Object (File)
Wed, May 3, 6:48 PM
Unknown Object (File)
Wed, May 3, 6:44 PM
Unknown Object (File)
Wed, May 3, 5:20 PM
Unknown Object (File)
Apr 25 2023, 3:56 PM
Unknown Object (File)
Apr 15 2023, 11:07 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. Further modularize build messages by applying each one in a separate transaction type.

This makes it easier to add new types of messages (although I have no particular plans to do this, offhand) and reduces the amount of switch-boilerplate.

This will probably also simplify validating "harbormaster.sendmessage".

Test Plan
  • Applied all commands.
  • Ran migration, saw transactions render properly

Diff Detail

Repository
rP Phabricator
Branch
build7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25455
Build 35178: Run Core Tests
Build 35177: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 15 2021, 10:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:17 PM
This revision was automatically updated to reflect the committed changes.