Page MenuHomePhabricator

Modularize individual Harbormaster build messages
ClosedPublic

Authored by epriestley on Jul 15 2021, 10:24 PM.
Tags
None
Referenced Files
F18364940: D21690.diff
Wed, Aug 27, 8:07 PM
F18199843: D21690.id51703.diff
Mon, Aug 18, 2:47 AM
F18106560: D21690.diff
Sun, Aug 10, 11:08 PM
F18003459: D21690.id.diff
Sat, Aug 2, 11:22 AM
F17973760: D21690.diff
Fri, Aug 1, 4:29 PM
Unknown Object (File)
Jun 1 2025, 7:49 PM
Unknown Object (File)
May 28 2025, 11:48 AM
Unknown Object (File)
May 27 2025, 4:14 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13072. Further modularize build messages by applying each one in a separate transaction type.

This makes it easier to add new types of messages (although I have no particular plans to do this, offhand) and reduces the amount of switch-boilerplate.

This will probably also simplify validating "harbormaster.sendmessage".

Test Plan
  • Applied all commands.
  • Ran migration, saw transactions render properly

Diff Detail

Repository
rP Phabricator
Branch
build7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25455
Build 35178: Run Core Tests
Build 35177: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 15 2021, 10:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:17 PM
This revision was automatically updated to reflect the committed changes.