Lift peculiar side effect of path indexing out of indexer
ClosedPublic
Actions

Authored by epriestley on Mar 15 2021, 5:50 PM.

Details

Reviewers: None
Maniphest Tasks: T13639: Allow revisions to be queried by affected path via the API
Commits: rPc317d16bdd56: Lift peculiar side effect of path indexing out of indexer

Summary

Ref T13639. Updating the affected path table has a peculiar side effect from D19426, which is a simplification of a peculiar side effect from earlier.

Don't condition Owners behavior on path index behavior.

Test Plan

Created a revision.

Diff Detail

Repository

rP Phabricator

Branch

recent3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25258
Build 34862: Run Core Tests
Build 34861: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 15 2021, 5:50 PM

Harbormaster completed remote builds in B25258: Diff 51450.Mar 15 2021, 5:51 PM

epriestley requested review of this revision.Mar 15 2021, 5:51 PM

After this change, we always execute this code for any update. This is sort-of a functional change, but likely moot or moot-adjacent in practice. Previously:

We'd reach this code only if the revision belonged to a repository. However, the reader of these properties checks for a repository anyway so this should be moot.
We'd previously reach this code only if the change included changesets, but it's very unusual for a change to not have changesets and there are some other outstanding issues related to empty diffs, so I'll just let that sort out in the wash.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 15 2021, 11:16 PM

Closed by commit rPc317d16bdd56: Lift peculiar side effect of path indexing out of indexer (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPc317d16bdd56: Lift peculiar side effect of path indexing out of indexer.