Page MenuHomePhabricator

Improve routing of "/robots.txt", "/favicon.ico", "/status/", and 404 on custom Sites
ClosedPublic

Authored by epriestley on Mar 11 2021, 9:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 8:30 PM
Unknown Object (File)
Tue, Nov 19, 7:09 AM
Unknown Object (File)
Sun, Nov 17, 9:45 PM
Unknown Object (File)
Thu, Nov 14, 5:58 AM
Unknown Object (File)
Wed, Nov 13, 7:24 PM
Unknown Object (File)
Sun, Nov 10, 5:52 AM
Unknown Object (File)
Thu, Nov 7, 6:55 PM
Unknown Object (File)
Tue, Nov 5, 10:55 PM
Subscribers
None

Details

Summary

Fixes T12919. Fixes T13636. Prior to this change, some well-known resource paths don't route on sites like ResourceSite.

  • /robots.txt: Make it route on ResourceSite and just deny the whole site.
  • /favicon.ico: Make it route on ResourceSite.
  • /status/: Make it route on ResourceSite.
  • 404: Make it render a 404 on ResourceSite.
Test Plan
  • Visited all URIs on ResourceSite, got sensible responses.
  • Visited all URIs on main site.
  • Visited 404 while logged out, got login page.

Diff Detail

Repository
rP Phabricator
Branch
robots1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25242
Build 34838: Run Core Tests
Build 34837: arc lint + arc unit