Paths

Table of Contentst

", and 404 on custom Sites
ClosedPublic
Actions

Authored by epriestley on Mar 11 2021, 9:42 PM.

Details

Reviewers: None
Maniphest Tasks: T12919: Healthcheck endpoint for alternate file domain
T13636: Some "well-known" resources can't be served from ResourceSite
Commits: rP36c6eb966393: Improve routing of "/robots.txt", "/favicon.ico", "/status/", and 404 on custom…

Summary

Fixes T12919. Fixes T13636. Prior to this change, some well-known resource paths don't route on sites like ResourceSite.

/robots.txt: Make it route on ResourceSite and just deny the whole site.
/favicon.ico: Make it route on ResourceSite.
/status/: Make it route on ResourceSite.
404: Make it render a 404 on ResourceSite.

Test Plan

Visited all URIs on ResourceSite, got sensible responses.
Visited all URIs on main site.
Visited 404 while logged out, got login page.

Diff Detail

Repository

rP Phabricator

Branch

robots1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25242
Build 34838: Run Core Tests
Build 34837: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 11 2021, 9:42 PM

Harbormaster completed remote builds in B25242: Diff 51435.Mar 11 2021, 9:43 PM

epriestley requested review of this revision.Mar 11 2021, 9:43 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2021, 10:05 PM

Closed by commit rP36c6eb966393: Improve routing of "/robots.txt", "/favicon.ico", "/status/", and 404 on custom… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP36c6eb966393: Improve routing of "/robots.txt", "/favicon.ico", "/status/", and 404 on custom….

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

aphront/

configuration/

AphrontApplicationConfiguration.php

9 lines

response/

Aphront404Response.php

9 lines

site/

AphrontSite.php

2 lines

PhabricatorPlatformSite.php

4 lines

applications/

auth/

extension/

PhabricatorAuthMainMenuBarExtension.php

8 lines

base/

controller/

Phabricator404Controller.php

7 lines

	PhabricatorPlatform404Controller.php
	Phabricator404Controller.php

3 lines

system/

application/

PhabricatorSystemApplication.php

10 lines

controller/

PhabricatorRobotsController.php

22 lines

PhabricatorRobotsPlatformController.php

25 lines

PhabricatorRobotsResourceController.php

17 lines

Diff 51435

View Options

src/__phutil_library_map__.php

View Options

src/aphront/configuration/AphrontApplicationConfiguration.php

View Options

src/aphront/response/Aphront404Response.php

View Options

src/aphront/site/AphrontSite.php

View Options

src/aphront/site/PhabricatorPlatformSite.php

View Options

src/applications/auth/extension/PhabricatorAuthMainMenuBarExtension.php

View Options

src/applications/base/controller/Phabricator404Controller.php

View Options

src/applications/base/controller/PhabricatorPlatform404Controller.php

View Options

src/applications/system/application/PhabricatorSystemApplication.php

View Options

src/applications/system/controller/PhabricatorRobotsController.php

View Options

src/applications/system/controller/PhabricatorRobotsPlatformController.php

View Options

src/applications/system/controller/PhabricatorRobotsResourceController.php

Improve routing of "/robots.txt", "/favicon.ico", "/status/", and 404 on custom SitesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51435

src/__phutil_library_map__.php

src/aphront/configuration/AphrontApplicationConfiguration.php

src/aphront/response/Aphront404Response.php

src/aphront/site/AphrontSite.php

src/aphront/site/PhabricatorPlatformSite.php

src/applications/auth/extension/PhabricatorAuthMainMenuBarExtension.php

src/applications/base/controller/Phabricator404Controller.php

src/applications/base/controller/PhabricatorPlatform404Controller.php

src/applications/system/application/PhabricatorSystemApplication.php

src/applications/system/controller/PhabricatorRobotsController.php

src/applications/system/controller/PhabricatorRobotsPlatformController.php

src/applications/system/controller/PhabricatorRobotsResourceController.php

Improve routing of "/robots.txt", "/favicon.ico", "/status/", and 404 on custom Sites
ClosedPublic
Actions

Revision Contents
Changeset List