Page MenuHomePhabricator

Improve routing of "/robots.txt", "/favicon.ico", "/status/", and 404 on custom Sites
ClosedPublic

Authored by epriestley on Mar 11 2021, 9:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 3, 5:45 AM
Unknown Object (File)
Jun 4 2025, 11:03 PM
Unknown Object (File)
Jun 2 2025, 5:10 AM
Unknown Object (File)
May 10 2025, 3:40 AM
Unknown Object (File)
Apr 10 2025, 9:52 AM
Unknown Object (File)
Apr 8 2025, 10:27 PM
Unknown Object (File)
Mar 28 2025, 7:51 AM
Unknown Object (File)
Mar 27 2025, 12:19 PM
Subscribers
None

Details

Summary

Fixes T12919. Fixes T13636. Prior to this change, some well-known resource paths don't route on sites like ResourceSite.

  • /robots.txt: Make it route on ResourceSite and just deny the whole site.
  • /favicon.ico: Make it route on ResourceSite.
  • /status/: Make it route on ResourceSite.
  • 404: Make it render a 404 on ResourceSite.
Test Plan
  • Visited all URIs on ResourceSite, got sensible responses.
  • Visited all URIs on main site.
  • Visited 404 while logged out, got login page.

Diff Detail

Repository
rP Phabricator
Branch
robots1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25242
Build 34838: Run Core Tests
Build 34837: arc lint + arc unit