Page MenuHomePhabricator

Improve routing of "/robots.txt", "/favicon.ico", "/status/", and 404 on custom Sites
ClosedPublic

Authored by epriestley on Mar 11 2021, 9:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 8:22 PM
Unknown Object (File)
Wed, Mar 27, 8:22 PM
Unknown Object (File)
Wed, Mar 27, 8:22 PM
Unknown Object (File)
Wed, Mar 27, 8:22 PM
Unknown Object (File)
Mar 10 2024, 5:58 AM
Unknown Object (File)
Mar 3 2024, 6:07 AM
Unknown Object (File)
Feb 9 2024, 3:30 AM
Unknown Object (File)
Feb 4 2024, 12:47 AM
Subscribers
None

Details

Summary

Fixes T12919. Fixes T13636. Prior to this change, some well-known resource paths don't route on sites like ResourceSite.

  • /robots.txt: Make it route on ResourceSite and just deny the whole site.
  • /favicon.ico: Make it route on ResourceSite.
  • /status/: Make it route on ResourceSite.
  • 404: Make it render a 404 on ResourceSite.
Test Plan
  • Visited all URIs on ResourceSite, got sensible responses.
  • Visited all URIs on main site.
  • Visited 404 while logged out, got login page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable