Page MenuHomePhabricator
Differential D21556

When a revision has only human reviewers but none can view it, show a warning banner
ClosedPublic
Actions

Authored by epriestley on Feb 13 2021, 9:21 PM.
Tags
None
Referenced Files
F19083425: D21556.id51316.diff
Tue, Dec 2, 12:35 PM
F19004998: D21556.id.diff
Nov 21 2025, 1:29 PM
F18993602: D21556.id51308.diff
Nov 19 2025, 8:12 AM
F18912410: D21556.diff
Nov 9 2025, 4:57 AM
F18842269: D21556.diff
Oct 28 2025, 2:35 PM
F18810999: D21556.diff
Oct 20 2025, 12:30 AM
F18805059: D21556.id.diff
Oct 18 2025, 1:33 PM
F18799331: D21556.diff
Oct 17 2025, 1:14 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers
Commits
rP42c26821ef92: When a revision has only human reviewers but none can view it, show a warning…
Summary

Ref T13602. Warn when a reivison has at least one human reviewer, no non-human reviewers, and no human reviewers can view it.

Test Plan

Screen Shot 2021-02-13 at 1.18.47 PM.png (284×570 px, 22 KB)

Diff Detail

Repository
rP Phabricator
Branch
policy7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25117
Build 34662: Run Core Tests
Build 34661: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2021, 9:21 PM
Harbormaster completed remote builds in B25117: Diff 51308.Feb 13 2021, 9:22 PM
epriestley requested review of this revision.Feb 13 2021, 9:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2021, 9:38 PM
Closed by commit rP42c26821ef92: When a revision has only human reviewers but none can view it, show a warning… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP42c26821ef92: When a revision has only human reviewers but none can view it, show a warning….

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
customfield/
24 lines

Diff 51308

View Options

src/applications/differential/customfield/DifferentialReviewersField.php

Loading...
Phabricator · Built by Phacility