When a revision has only human reviewers but none can view it, show a warning banner
ClosedPublic
Actions

Authored by epriestley on Feb 13 2021, 9:21 PM.

Tags

None

Referenced Files

	F18795613: D21556.diff
	Fri, Oct 17, 2:14 AM

	F18743549: D21556.id.diff
	Fri, Oct 3, 12:03 AM

	F18734392: D21556.id.diff
	Tue, Sep 30, 10:53 PM

	F18684966: D21556.id51308.diff
	Fri, Sep 26, 10:15 AM

	F18658557: D21556.id51316.diff
	Tue, Sep 23, 7:12 AM

	F18622804: D21556.diff
	Sep 15 2025, 1:03 PM

	F18601811: D21556.id.diff
	Sep 13 2025, 1:33 PM

	F18593018: D21556.diff
	Sep 12 2025, 1:41 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers
Commits: rP42c26821ef92: When a revision has only human reviewers but none can view it, show a warning…

Summary

Ref T13602. Warn when a reivison has at least one human reviewer, no non-human reviewers, and no human reviewers can view it.

Test Plan

Screen Shot 2021-02-13 at 1.18.47 PM.png (284×570 px, 22 KB)

Diff Detail

Repository

rP Phabricator

Branch

policy7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25117
Build 34662: Run Core Tests
Build 34661: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2021, 9:21 PM

Harbormaster completed remote builds in B25117: Diff 51308.Feb 13 2021, 9:22 PM

epriestley requested review of this revision.Feb 13 2021, 9:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2021, 9:38 PM

Closed by commit rP42c26821ef92: When a revision has only human reviewers but none can view it, show a warning… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP42c26821ef92: When a revision has only human reviewers but none can view it, show a warning….

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialReviewersField.php

24 lines

Diff 51308

View Options

src/applications/differential/customfield/DifferentialReviewersField.php

When a revision has only human reviewers but none can view it, show a warning bannerClosedPublicActions