Page MenuHomePhabricator
Differential D21538

Allow lint to correct the spelling of builtin symbols
ClosedPublic
Actions

Authored by epriestley on Feb 3 2021, 9:21 PM.
Tags
None
Referenced Files
F13100836: D21538.diff
Fri, Apr 26, 8:24 PM
F13099293: D21538.diff
Fri, Apr 26, 2:30 PM
Unknown Object (File)
Wed, Apr 24, 11:07 PM
Unknown Object (File)
Sun, Apr 7, 9:35 PM
Unknown Object (File)
Thu, Apr 4, 2:35 AM
Unknown Object (File)
Fri, Mar 29, 7:49 PM
Unknown Object (File)
Feb 9 2024, 1:41 AM
Unknown Object (File)
Dec 30 2023, 5:40 PM
View All 90 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13598: Lint raises symbol capitalization errors as "Unknown Symbol" errors
Commits
rARCe2b6439a734b: Allow lint to correct the spelling of builtin symbols
Summary

Ref T13598. This builds on D21537 and adds support for correcting the capitalization of builtin systems.

Test Plan
  • Linted a file that uses "ExCePtIoN", got a lint correction.

Diff Detail

Repository
rARC Arcanist
Branch
lint2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25082
Build 34610: Run Core Tests
Build 34609: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 3 2021, 9:21 PM
Harbormaster completed remote builds in B25081: Diff 51267.Feb 3 2021, 9:22 PM
epriestley requested review of this revision.Feb 3 2021, 9:22 PM
epriestley updated this revision to Diff 51268.Feb 3 2021, 9:22 PM
  • Slight formatting improvement.
Harbormaster completed remote builds in B25082: Diff 51268.Feb 3 2021, 9:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 9:26 PM
Closed by commit rARCe2b6439a734b: Allow lint to correct the spelling of builtin symbols (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCe2b6439a734b: Allow lint to correct the spelling of builtin symbols.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
67 lines
moduleutils/
22 lines
support/
lib/
54 lines

Diff 51268

View Options

src/lint/linter/ArcanistPhutilLibraryLinter.php

Loading...
View Options

src/moduleutils/PhutilLibraryMapBuilder.php

Loading...
View Options

support/lib/extract-symbols.php

Loading...
Phabricator · Built by Phacility