Page MenuHomePhabricator

Log unexpected exceptions raised by Conduit calls
ClosedPublic

Authored by epriestley on Sep 16 2020, 12:24 AM.
Tags
None
Referenced Files
F15471061: D21464.id.diff
Sat, Apr 5, 3:02 AM
F15466545: D21464.id51091.diff
Thu, Apr 3, 6:48 AM
F15445013: D21464.id.diff
Thu, Mar 27, 12:18 PM
F15442063: D21464.diff
Wed, Mar 26, 9:10 PM
F15332706: D21464.diff
Mar 7 2025, 7:24 PM
Unknown Object (File)
Feb 9 2025, 5:19 PM
Unknown Object (File)
Feb 9 2025, 9:53 AM
Unknown Object (File)
Feb 9 2025, 9:53 AM
Subscribers
None

Details

Summary

Ref T13581. Currently, unexpected exceptions inside Conduit calls are passed to the client, but not logged on the server.

These exceptions should generally be unexpected, and producing a server-side trace is potentially useful.

Test Plan

Simulated a during-execution exception, saw it get logged on the server.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:37 AM
This revision was automatically updated to reflect the committed changes.