Log unexpected exceptions raised by Conduit calls
ClosedPublic
Actions

Authored by epriestley on Sep 16 2020, 12:24 AM.

Details

Reviewers: None
Maniphest Tasks: T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash
Commits: rP969587f7b0c3: Log unexpected exceptions raised by Conduit calls

Summary

Ref T13581. Currently, unexpected exceptions inside Conduit calls are passed to the client, but not logged on the server.

These exceptions should generally be unexpected, and producing a server-side trace is potentially useful.

Test Plan

Simulated a during-execution exception, saw it get logged on the server.

Repository

rP Phabricator

Branch

cref15

Lint

Lint Passed

Unit

Tests Passed

Build Status

epriestley requested review of this revision.Sep 16 2020, 12:25 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:37 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

conduit/

controller/

14 lines