Page MenuHomePhabricator

In "arc branches", group linear sequences of published revisions together
ClosedPublic

Authored by epriestley on Jun 17 2020, 5:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 11:45 PM
Unknown Object (File)
Wed, Mar 13, 5:24 PM
Unknown Object (File)
Sat, Mar 9, 5:01 PM
Unknown Object (File)
Wed, Mar 6, 4:07 AM
Unknown Object (File)
Mon, Mar 4, 6:47 AM
Unknown Object (File)
Fri, Mar 1, 4:44 PM
Unknown Object (File)
Feb 26 2024, 4:36 PM
Unknown Object (File)
Feb 23 2024, 10:45 PM
Subscribers
None

Details

Summary

Ref T13546. If your history includes a long linear sequence of published revisions, summarize them.

Test Plan

Ran "arc branches", saw better summarization of linear published revision sequences.

Diff Detail

Repository
rARC Arcanist
Branch
landx15
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/repository/graph/view/ArcanistCommitGraphSetView.php:344XHP1PHP Syntax Error!
Unit
Test Failures
Build Status
Buildable 24674
Build 34025: Run Core Tests
Build 34024: arc lint + arc unit

Unit TestsFailed

TimeTest
132 msPhutilLibraryTestCase::testLibraryMap
EXCEPTION (XHPASTSyntaxErrorException): repository/graph/view/ArcanistCommitGraphSetView.php: XHPAST Parse Error: syntax error, unexpected ')' on line 344 #0 /Users/epriestley/dev/core/lib/arcanist/src/moduleutils/PhutilLibraryMapBuilder.php(77): PhutilLibraryMapBuilder->analyzeLibrary() #1 /Users/epriestley/dev/core/lib/arcanist/src/__tests__/PhutilLibraryTestCase.php(29): PhutilLibraryMapBuilder->buildMap()
0 msArcanistCommitGraphTestCase::testGraphQuery
5 assertion(s) passed.
0 msPhutilLibraryTestCase::testEverythingImplemented
1 assertion(s) passed.
81 msPhutilLibraryTestCase::testMethodVisibility
1 assertion(s) passed.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 17 2020, 5:37 PM
Harbormaster failed remote builds in B24674: Diff 50855!
This revision was not accepted when it landed; it landed in state Needs Review.Jun 30 2020, 10:50 PM
This revision was automatically updated to reflect the committed changes.