Page MenuHomePhabricator
Differential D21347

In "arc land", fix some coarse issues with build warnings
ClosedPublic
Actions

Authored by epriestley on Jun 10 2020, 5:16 PM.
Tags
None
Referenced Files
F14800410: D21347.id50816.diff
Sat, Jan 25, 8:14 AM
F14800409: D21347.id50811.diff
Sat, Jan 25, 8:14 AM
F14800408: D21347.id.diff
Sat, Jan 25, 8:14 AM
Unknown Object (File)
Tue, Jan 21, 9:54 AM
Unknown Object (File)
Sat, Jan 11, 1:57 PM
Unknown Object (File)
Thu, Jan 2, 11:35 PM
Unknown Object (File)
Thu, Jan 2, 2:26 AM
Unknown Object (File)
Dec 17 2024, 9:43 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13546: Modernize the "arc land" workflow
Commits
rARC727d73fec937: In "arc land", fix some coarse issues with build warnings
Summary

Ref T13546. In the new "arc land": actually reach build warnings; and show buildable URIs.

Test Plan

Ran "arc land ..." with intentionally broken builds, got more useful build warnings.

Diff Detail

Repository
rARC Arcanist
Branch
hg5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24632
Build 33959: Run Core Tests
Build 33958: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 10 2020, 5:16 PM
Harbormaster completed remote builds in B24632: Diff 50811.Jun 10 2020, 5:16 PM
epriestley requested review of this revision.Jun 10 2020, 5:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 10 2020, 5:27 PM
Closed by commit rARC727d73fec937: In "arc land", fix some coarse issues with build warnings (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC727d73fec937: In "arc land", fix some coarse issues with build warnings.

Revision Contents
Changeset List

PathSize
src/
land/
engine/
17 lines
ref/
build/
2 lines
buildable/
16 lines
workflow/
2 lines

Diff 50811

View Options

src/land/engine/ArcanistLandEngine.php

Loading...
View Options

src/ref/build/ArcanistBuildBuildplanHardpointQuery.php

Loading...
View Options

src/ref/buildable/ArcanistBuildableRef.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility