Differential D21303

Remove "--ignore-unsound-tests" from "arc diff"
ClosedPublic
Actions

Authored by epriestley on May 30 2020, 10:49 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 6, 12:19 AM

	Unknown Object (File)
	Fri, May 3, 7:53 AM

	Unknown Object (File)
	Fri, Apr 26, 2:47 AM

	Unknown Object (File)
	Thu, Apr 25, 1:49 AM

	Unknown Object (File)
	Thu, Apr 18, 3:42 AM

	Unknown Object (File)
	Apr 1 2024, 6:51 AM

	Unknown Object (File)
	Mar 30 2024, 3:19 AM

	Unknown Object (File)
	Mar 3 2024, 2:00 PM

View All 64 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13544: Modernize the "arc diff" workflow
Commits: rARC86471fc0feac: Remove "--ignore-unsound-tests" from "arc diff"

Summary

Ref T13544. This flag only disables a warning and should be a prompt default, not a flag.

Test Plan

Grepped for "ignore-unsound-tests", created this revision.

Diff Detail

Repository

Branch

xdiff8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24542
Build 33825: Run Core Tests
Build 33824: arc lint + arc unit

Event Timeline

epriestley created this revision.May 30 2020, 10:49 PM

Harbormaster completed remote builds in B24542: Diff 50720.May 30 2020, 10:50 PM

epriestley requested review of this revision.May 30 2020, 10:50 PM

epriestley added a child revision: D21304: Remove "--amend-all", "--no-amend", and "--amend-autofixes" from "arc diff".Jun 3 2020, 7:48 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 10:58 PM

Closed by commit rARC86471fc0feac: Remove "--ignore-unsound-tests" from "arc diff" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC86471fc0feac: Remove "--ignore-unsound-tests" from "arc diff".

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

31 lines

Diff 50720

src/workflow/ArcanistDiffWorkflow.php

Loading...