Page MenuHomePhabricator

Remove "--use-commit-message/-C" from "arc diff"
ClosedPublic

Authored by epriestley on May 30 2020, 9:34 PM.
Tags
None
Referenced Files
F15490014: D21296.id50739.diff
Fri, Apr 11, 2:03 PM
F15458882: D21296.diff
Mon, Mar 31, 8:00 AM
F15458052: D21296.id50712.diff
Sun, Mar 30, 8:31 PM
F15441476: D21296.id.diff
Wed, Mar 26, 6:27 PM
F15437264: D21296.diff
Tue, Mar 25, 6:37 PM
F15424237: D21296.id50712.diff
Mar 22 2025, 9:04 PM
F15410970: D21296.diff
Mar 19 2025, 8:44 AM
F15410201: D21296.diff
Mar 19 2025, 6:53 AM
Subscribers
None

Details

Summary

Ref T13544. This flag was introduced in D1385 (2012) as part of a workflow which no longer exists. I can't recall anyone ever reporting an issue which involves its use and believe it is likely unused. It's not obvious to me why someone would use it in modern "arc".

(The same goal can be accomplished with "--message-file ...", although this requires more steps.)

Test Plan

Grepped for "use-commit-message" and "getCommitMessageFromCommit", ran "arc diff".

Diff Detail

Repository
rARC Arcanist
Branch
xdiff1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24534
Build 33810: Run Core Tests
Build 33809: arc lint + arc unit