Page MenuHomePhabricator

Fix two rendering issues with Jupyter notebooks
ClosedPublic

Authored by epriestley on May 22 2020, 6:51 PM.
Tags
None
Referenced Files
F19097488: D21285.diff
Thu, Dec 4, 1:38 PM
F19068076: D21285.id.diff
Sun, Nov 30, 11:24 AM
F18857297: D21285.id.diff
Nov 1 2025, 2:30 PM
F18852135: D21285.diff
Oct 31 2025, 6:56 AM
F18850851: D21285.id50684.diff
Oct 30 2025, 7:47 PM
F18803508: D21285.id50683.diff
Oct 18 2025, 12:37 AM
F18706003: D21285.id.diff
Sep 28 2025, 2:33 PM
F18704273: D21285.diff
Sep 28 2025, 6:52 AM
Subscribers
None

Details

Summary

See PHI1752.

  • Early exit of document layout can cause us to fail to populate available rows.
  • Some Jupyter documents have "markdown" cells with plain strings, apparently.
Test Plan

Successfully rendered example diff from PHI1752.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 22 2020, 6:52 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.