Page MenuHomePhabricator

Fix two rendering issues with Jupyter notebooks
ClosedPublic

Authored by epriestley on May 22 2020, 6:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 5:01 AM
Unknown Object (File)
Thu, Apr 25, 2:09 AM
Unknown Object (File)
Tue, Apr 23, 6:52 PM
Unknown Object (File)
Tue, Apr 23, 6:52 PM
Unknown Object (File)
Sat, Apr 20, 1:43 AM
Unknown Object (File)
Thu, Apr 11, 5:21 PM
Unknown Object (File)
Sun, Mar 31, 12:42 PM
Unknown Object (File)
Jan 11 2024, 12:02 PM
Subscribers
None

Details

Summary

See PHI1752.

  • Early exit of document layout can cause us to fail to populate available rows.
  • Some Jupyter documents have "markdown" cells with plain strings, apparently.
Test Plan

Successfully rendered example diff from PHI1752.

Diff Detail

Repository
rP Phabricator
Branch
rowcount1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24502
Build 33767: Run Core Tests
Build 33766: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 22 2020, 6:52 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.