Differential D21285

Fix two rendering issues with Jupyter notebooks
ClosedPublic
Actions

Authored by epriestley on May 22 2020, 6:51 PM.

Details

Reviewers: None
Commits: rP828798f3e1b4: (stable) Fix two rendering issues with Jupyter notebooks
rP4fd0628fae45: Fix two rendering issues with Jupyter notebooks

Summary

See PHI1752.

Early exit of document layout can cause us to fail to populate available rows.
Some Jupyter documents have "markdown" cells with plain strings, apparently.

Test Plan

Successfully rendered example diff from PHI1752.

Diff Detail

Repository

rP Phabricator

Branch

rowcount1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24502
Build 33767: Run Core Tests
Build 33766: arc lint + arc unit

Event Timeline

epriestley created this revision.May 22 2020, 6:51 PM

Harbormaster completed remote builds in B24502: Diff 50683.May 22 2020, 6:52 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 22 2020, 6:52 PM

epriestley requested review of this revision.

Closed by commit rP4fd0628fae45: Fix two rendering issues with Jupyter notebooks (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP4fd0628fae45: Fix two rendering issues with Jupyter notebooks.

epriestley added a commit: rP828798f3e1b4: (stable) Fix two rendering issues with Jupyter notebooks.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

diff/

PhabricatorDocumentEngineBlocks.php

1 line

document/

PhabricatorJupyterDocumentEngine.php

19 lines

Diff 50683

View Options

src/applications/files/diff/PhabricatorDocumentEngineBlocks.php