Page MenuHomePhabricator

Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the worker queue
ClosedPublic

Authored by epriestley on May 19 2020, 5:39 PM.
Tags
None
Referenced Files
F13492176: D21271.id50651.diff
Mon, Jul 22, 10:32 AM
F13492085: D21271.id50654.diff
Mon, Jul 22, 10:02 AM
F13491411: D21271.diff
Mon, Jul 22, 6:50 AM
Unknown Object (File)
Sat, Jul 20, 3:46 AM
Unknown Object (File)
Wed, Jul 17, 12:45 PM
Unknown Object (File)
Wed, Jul 17, 6:15 AM
Unknown Object (File)
Sun, Jul 14, 5:44 PM
Unknown Object (File)
Sun, Jul 14, 5:18 AM
Subscribers
None

Details

Summary

See PHI1745. See T12855. Under PHP7, errors raised as Throwable miss this "generic exception" logic and don't increment their failure count. Instead, treat any "Throwable" we don't recognize like any "Exception" we don't recognize.

Test Plan
  • Under PHP7, caused a worker task to raise a Throwable (e.g., call to undefined method, see D21270).
  • Ran bin/worker execute --id ....
  • Before: worker failed, but did not increment failure count.
  • After: worker fails and increments failure count as it would for other types of unknown error.

Diff Detail

Repository
rP Phabricator
Branch
throwable1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24470
Build 33719: Run Core Tests
Build 33718: arc lint + arc unit