Page MenuHomePhabricator

Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the worker queue
ClosedPublic

Authored by epriestley on May 19 2020, 5:39 PM.
Tags
None
Referenced Files
F13344432: D21271.diff
Fri, Jun 21, 7:42 AM
F13333629: D21271.id50654.diff
Tue, Jun 18, 8:30 AM
F13329439: D21271.id.diff
Mon, Jun 17, 12:17 AM
F13282124: D21271.diff
Sun, Jun 2, 11:44 AM
F13188188: D21271.diff
May 11 2024, 5:04 AM
Unknown Object (File)
May 7 2024, 8:18 AM
Unknown Object (File)
May 3 2024, 8:02 AM
Unknown Object (File)
Apr 29 2024, 7:27 PM
Subscribers
None

Details

Summary

See PHI1745. See T12855. Under PHP7, errors raised as Throwable miss this "generic exception" logic and don't increment their failure count. Instead, treat any "Throwable" we don't recognize like any "Exception" we don't recognize.

Test Plan
  • Under PHP7, caused a worker task to raise a Throwable (e.g., call to undefined method, see D21270).
  • Ran bin/worker execute --id ....
  • Before: worker failed, but did not increment failure count.
  • After: worker fails and increments failure count as it would for other types of unknown error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable