Paths

Table of Contentst

Fix a JS issue when the anchor element on a page has no container
ClosedPublic
Actions

Authored by epriestley on May 4 2020, 10:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 4:41 AM

	Unknown Object (File)
	Fri, Nov 22, 7:57 PM

	Unknown Object (File)
	Wed, Nov 20, 9:34 AM

	Unknown Object (File)
	Sat, Nov 16, 1:40 PM

	Unknown Object (File)
	Tue, Nov 12, 5:00 AM

	Unknown Object (File)
	Fri, Nov 8, 2:06 PM

	Unknown Object (File)
	Oct 24 2024, 3:20 PM

	Unknown Object (File)
	Oct 21 2024, 5:13 PM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP6b69102990a3: Fix a JS issue when the anchor element on a page has no container

Summary

See D21213. If there's no matching element, findAbove() throws. Handle these cases correctly.

Test Plan

Visited #toc on a revision, no longer saw a JS error.

Diff Detail

Repository

rP Phabricator

Branch

anchor1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24357
Build 33555: Run Core Tests
Build 33554: arc lint + arc unit

Event Timeline

epriestley created this revision.May 4 2020, 10:50 PM

Harbormaster completed remote builds in B24357: Diff 50541.May 4 2020, 10:51 PM

epriestley requested review of this revision.May 4 2020, 10:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 10:57 PM

Closed by commit rP6b69102990a3: Fix a JS issue when the anchor element on a page has no container (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6b69102990a3: Fix a JS issue when the anchor element on a page has no container.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

core/

behavior-watch-anchor.js

10 lines

Diff 50541

View Options

resources/celerity/map.php