Page MenuHomePhabricator

Restore highlighting when jumping to transactions using URI anchors
ClosedPublic

Authored by epriestley on May 4 2020, 5:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 12:26 AM
Unknown Object (File)
Tue, Jan 14, 12:31 AM
Unknown Object (File)
Mon, Jan 13, 4:30 PM
Unknown Object (File)
Mon, Dec 30, 12:27 PM
Unknown Object (File)
Sat, Dec 28, 3:03 PM
Unknown Object (File)
Sat, Dec 28, 12:26 PM
Unknown Object (File)
Dec 16 2024, 5:52 AM
Unknown Object (File)
Dec 16 2024, 5:51 AM
Subscribers
None

Details

Summary

At some point, the highlighting behavior for the timeline broke. When you follow a link to a particular timeline story, the story should be highlighted.

Prior to this change, the <a /> tag itself highlights, but there's no associated CSS and it's too deep in the tree to do anything useful.

(Since this change is fairly straightforward, I gave up digging for the root cause before finding it.)

Test Plan
  • Clicked a timeline story anchor, saw the story highlight.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable