Page MenuHomePhabricator

Restore highlighting when jumping to transactions using URI anchors
ClosedPublic

Authored by epriestley on May 4 2020, 5:01 PM.
Tags
None
Referenced Files
F18773210: D21213.id.diff
Thu, Oct 9, 8:12 AM
F18734288: D21213.id.diff
Tue, Sep 30, 10:51 PM
F18652767: D21213.id50516.diff
Sun, Sep 21, 9:28 AM
F18649533: D21213.diff
Sat, Sep 20, 9:13 PM
F18631578: D21213.diff
Sep 16 2025, 3:46 PM
F18605435: D21213.diff
Sep 13 2025, 8:30 PM
F18487727: D21213.diff
Sep 3 2025, 8:03 PM
F18422189: D21213.diff
Aug 30 2025, 5:49 PM
Subscribers
None

Details

Summary

At some point, the highlighting behavior for the timeline broke. When you follow a link to a particular timeline story, the story should be highlighted.

Prior to this change, the <a /> tag itself highlights, but there's no associated CSS and it's too deep in the tree to do anything useful.

(Since this change is fairly straightforward, I gave up digging for the root cause before finding it.)

Test Plan
  • Clicked a timeline story anchor, saw the story highlight.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable