Page MenuHomePhabricator

Restore highlighting when jumping to transactions using URI anchors
ClosedPublic

Authored by epriestley on May 4 2020, 5:01 PM.
Tags
None
Referenced Files
F19083324: D21213.id50516.diff
Tue, Dec 2, 12:34 PM
F19033473: D21213.diff
Tue, Nov 25, 10:35 AM
F19019234: D21213.diff
Nov 23 2025, 1:56 PM
F18985481: D21213.id50515.diff
Nov 17 2025, 1:04 PM
F18840030: D21213.diff
Oct 27 2025, 8:40 PM
F18813265: D21213.diff
Oct 20 2025, 2:56 PM
F18773210: D21213.id.diff
Oct 9 2025, 8:12 AM
F18734288: D21213.id.diff
Sep 30 2025, 10:51 PM
Subscribers
None

Details

Summary

At some point, the highlighting behavior for the timeline broke. When you follow a link to a particular timeline story, the story should be highlighted.

Prior to this change, the <a /> tag itself highlights, but there's no associated CSS and it's too deep in the tree to do anything useful.

(Since this change is fairly straightforward, I gave up digging for the root cause before finding it.)

Test Plan
  • Clicked a timeline story anchor, saw the story highlight.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable