Page MenuHomePhabricator

Restore highlighting when jumping to transactions using URI anchors
ClosedPublic

Authored by epriestley on May 4 2020, 5:01 PM.
Tags
None
Referenced Files
F15433651: D21213.diff
Tue, Mar 25, 12:14 AM
F15424326: D21213.id50515.diff
Sat, Mar 22, 9:32 PM
F15424120: D21213.diff
Sat, Mar 22, 8:15 PM
F15400030: D21213.diff
Mon, Mar 17, 9:14 AM
F15370136: D21213.diff
Wed, Mar 12, 9:14 AM
F15316113: D21213.id50516.diff
Mar 6 2025, 6:22 PM
F15316111: D21213.id.diff
Mar 6 2025, 6:22 PM
F15316110: D21213.diff
Mar 6 2025, 6:22 PM
Subscribers
None

Details

Summary

At some point, the highlighting behavior for the timeline broke. When you follow a link to a particular timeline story, the story should be highlighted.

Prior to this change, the <a /> tag itself highlights, but there's no associated CSS and it's too deep in the tree to do anything useful.

(Since this change is fairly straightforward, I gave up digging for the root cause before finding it.)

Test Plan
  • Clicked a timeline story anchor, saw the story highlight.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable