Page MenuHomePhabricator

Restore highlighting when jumping to transactions using URI anchors
ClosedPublic

Authored by epriestley on May 4 2020, 5:01 PM.
Tags
None
Referenced Files
F14080051: D21213.diff
Fri, Nov 22, 11:21 AM
Unknown Object (File)
Wed, Nov 20, 9:49 PM
Unknown Object (File)
Sun, Nov 17, 7:17 PM
Unknown Object (File)
Wed, Nov 13, 6:03 PM
Unknown Object (File)
Sun, Nov 10, 10:05 AM
Unknown Object (File)
Fri, Nov 8, 1:47 PM
Unknown Object (File)
Tue, Nov 5, 7:41 PM
Unknown Object (File)
Sun, Oct 27, 9:32 PM
Subscribers
None

Details

Summary

At some point, the highlighting behavior for the timeline broke. When you follow a link to a particular timeline story, the story should be highlighted.

Prior to this change, the <a /> tag itself highlights, but there's no associated CSS and it's too deep in the tree to do anything useful.

(Since this change is fairly straightforward, I gave up digging for the root cause before finding it.)

Test Plan
  • Clicked a timeline story anchor, saw the story highlight.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable