Page MenuHomePhabricator

Restore highlighting when jumping to transactions using URI anchors
ClosedPublic

Authored by epriestley on May 4 2020, 5:01 PM.
Tags
None
Referenced Files
F18052026: D21213.id50516.diff
Mon, Aug 4, 1:15 AM
F18050528: D21213.id.diff
Sun, Aug 3, 8:14 PM
F18023239: D21213.diff
Sat, Aug 2, 8:52 PM
F17949082: D21213.id50516.diff
Thu, Jul 31, 10:50 PM
F17899547: D21213.diff
Tue, Jul 29, 8:40 AM
Unknown Object (File)
May 6 2025, 6:48 AM
Unknown Object (File)
Apr 24 2025, 1:32 PM
Unknown Object (File)
Apr 21 2025, 8:42 AM
Subscribers
None

Details

Summary

At some point, the highlighting behavior for the timeline broke. When you follow a link to a particular timeline story, the story should be highlighted.

Prior to this change, the <a /> tag itself highlights, but there's no associated CSS and it's too deep in the tree to do anything useful.

(Since this change is fairly straightforward, I gave up digging for the root cause before finding it.)

Test Plan
  • Clicked a timeline story anchor, saw the story highlight.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable