Paths

Table of Contentst

Diffusion Phabricator 6b69102990a3

Fix a JS issue when the anchor element on a page has no container
6b69102990a3
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Fix a JS issue when the anchor element on a page has no container

Summary: See D21213. If there's no matching element, findAbove() throws. Handle these cases correctly.

Test Plan: Visited #toc on a revision, no longer saw a JS error.

Differential Revision: https://secure.phabricator.com/D21222

Details

Provenance

epriestley	Authored on May 4 2020, 10:48 PM
epriestley	Pushed on May 4 2020, 10:57 PM

Differential Revision

D21222: Fix a JS issue when the anchor element on a page has no container

Parents

rP6430d6d638eb: Fix an intradiff error when the newer changeset does not exist

Branches

Unknown

Tags

Unknown

Build Status

Buildable 24360
Build 33558: Run Core Tests

Event Timeline

epriestley committed rP6b69102990a3: Fix a JS issue when the anchor element on a page has no container (authored by epriestley).May 4 2020, 10:57 PM

epriestley added an edge: D21222: Fix a JS issue when the anchor element on a page has no container.

Harbormaster completed building B24360: rP6b69102990a3: Fix a JS issue when the anchor element on a page has no container.May 4 2020, 10:58 PM

Changes (2)

Path

Size

resources/

celerity/

webroot/

rsrc/

js/

core/

behavior-watch-anchor.js

rP6b69102990a3

resources/celerity/map.php

Loading...

webroot/rsrc/js/core/behavior-watch-anchor.js

Loading...