Page MenuHomePhabricator

Upgrade (most) Differential API callsites to "differential.revision.search"
ClosedPublic

Authored by epriestley on Apr 13 2020, 12:25 PM.
Tags
None
Referenced Files
F15473065: D21099.id50257.diff
Sat, Apr 5, 7:23 PM
F15437022: D21099.id.diff
Tue, Mar 25, 5:04 PM
F15434486: D21099.diff
Tue, Mar 25, 4:04 AM
F15434246: D21099.diff
Tue, Mar 25, 2:45 AM
Unknown Object (File)
Mar 3 2025, 4:42 AM
Unknown Object (File)
Feb 25 2025, 4:31 AM
Unknown Object (File)
Feb 21 2025, 11:14 PM
Unknown Object (File)
Feb 9 2025, 8:55 AM
Subscribers
None

Details

Summary

Ref T13490. The "RevisionRef" is currently based on "differential.query" data, but all calls other than the hash-based lookup can move to "differential.revision.search".

Test Plan

Ran revision workflows like arc inspect and arc browse.

Diff Detail

Repository
rARC Arcanist
Branch
xflow4
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/browse/workflow/ArcanistBrowseWorkflow.php:237XHP16TODO Comment
Advicesrc/ref/revision/ArcanistRevisionRef.php:74XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24073
Build 33141: Run Core Tests
Build 33140: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 13 2020, 1:42 PM
This revision was automatically updated to reflect the committed changes.