Page MenuHomePhabricator

Upgrade (most) Differential API callsites to "differential.revision.search"
ClosedPublic

Authored by epriestley on Apr 13 2020, 12:25 PM.
Tags
None
Referenced Files
F22563214: D21099.diff
Thu, Sep 24, 8:45 PM
Unknown Object (File)
Jul 3 2026, 10:46 AM
Unknown Object (File)
Jul 3 2026, 10:46 AM
Unknown Object (File)
Jul 3 2026, 6:43 AM
Unknown Object (File)
Jun 30 2026, 4:56 PM
Unknown Object (File)
Jun 28 2026, 5:06 AM
Unknown Object (File)
Jun 18 2026, 1:27 AM
Unknown Object (File)
Apr 7 2026, 6:32 AM
Subscribers
None

Details

Summary

Ref T13490. The "RevisionRef" is currently based on "differential.query" data, but all calls other than the hash-based lookup can move to "differential.revision.search".

Test Plan

Ran revision workflows like arc inspect and arc browse.

Diff Detail

Repository
rARC Arcanist
Branch
xflow4
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/browse/workflow/ArcanistBrowseWorkflow.php:237XHP16TODO Comment
Advicesrc/ref/revision/ArcanistRevisionRef.php:74XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24073
Build 33141: Run Core Tests
Build 33140: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 13 2020, 1:42 PM
This revision was automatically updated to reflect the committed changes.