Restore "%d" support to "tsprintf()"
ClosedPublic
Actions

Authored by epriestley on Apr 13 2020, 11:31 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 11, 9:05 AM

	Unknown Object (File)
	Mar 6 2024, 9:05 AM

	Unknown Object (File)
	Feb 16 2024, 10:42 AM

	Unknown Object (File)
	Jan 15 2024, 12:13 PM

	Unknown Object (File)
	Jan 7 2024, 6:55 AM

	Unknown Object (File)
	Dec 27 2023, 1:22 PM

	Unknown Object (File)
	Dec 25 2023, 7:35 AM

	Unknown Object (File)
	Dec 22 2023, 2:54 AM

View All 41 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits: rARCab589ab31d68: Restore "%d" support to "tsprintf()"

Summary

Ref T13490. I recently made "tsprintf()" more strict, but we do sometimes use "%d" and this is reasonable to support.

Test Plan

Ran "arc branch".

Diff Detail

Repository

rARC Arcanist

Branch

xflow3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24071
Build 33138: Run Core Tests
Build 33137: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 13 2020, 11:31 AM

Harbormaster completed remote builds in B24071: Diff 50253.Apr 13 2020, 11:32 AM

epriestley requested review of this revision.Apr 13 2020, 11:32 AM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 13 2020, 11:36 AM

Closed by commit rARCab589ab31d68: Restore "%d" support to "tsprintf()" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCab589ab31d68: Restore "%d" support to "tsprintf()".

Revision Contents
Changeset List

Path

Size

src/

xsprintf/

tsprintf.php

3 lines

Diff 50253

View Options

Restore "%d" support to "tsprintf()"ClosedPublicActions