Page MenuHomePhabricator

Upgrade "arc download" to Toolsets
ClosedPublic

Authored by epriestley on Apr 12 2020, 11:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 8:55 AM
Unknown Object (File)
Sun, Feb 9, 8:55 AM
Unknown Object (File)
Sun, Feb 9, 8:55 AM
Unknown Object (File)
Tue, Jan 28, 5:37 AM
Unknown Object (File)
Sat, Jan 25, 7:00 AM
Unknown Object (File)
Sat, Jan 25, 7:00 AM
Unknown Object (File)
Sat, Jan 25, 7:00 AM
Unknown Object (File)
Fri, Jan 24, 5:51 AM
Subscribers
None

Details

Summary

Ref T13490. This is mostly straightforward.

  • Drop "--show" in favor of "--as -".
  • Drop support for 4+ year old "file.info" API.
  • Use modern stream-to-disk support so we get a real progress bar and don't need to buffer files into memory.
Test Plan

Downloaded various files, including large files.

Diff Detail

Repository
rARC Arcanist
Branch
xflow2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/workflow/ArcanistDownloadWorkflow.php:166XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24068
Build 33134: Run Core Tests
Build 33133: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2020, 11:18 PM
This revision was automatically updated to reflect the committed changes.