Page MenuHomePhabricator

Upgrade "arc download" to Toolsets
ClosedPublic

Authored by epriestley on Apr 12 2020, 11:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 2 2024, 5:28 AM
Unknown Object (File)
Jan 28 2024, 1:21 AM
Unknown Object (File)
Dec 27 2023, 1:22 PM
Unknown Object (File)
Dec 23 2023, 5:04 AM
Unknown Object (File)
Dec 22 2023, 2:54 AM
Unknown Object (File)
Dec 13 2023, 4:03 AM
Unknown Object (File)
Nov 30 2023, 4:06 AM
Unknown Object (File)
Nov 16 2023, 11:36 PM
Subscribers
None

Details

Summary

Ref T13490. This is mostly straightforward.

  • Drop "--show" in favor of "--as -".
  • Drop support for 4+ year old "file.info" API.
  • Use modern stream-to-disk support so we get a real progress bar and don't need to buffer files into memory.
Test Plan

Downloaded various files, including large files.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2020, 11:18 PM
This revision was automatically updated to reflect the committed changes.