Differential D21095

Update "arc amend" for Toolsets
ClosedPublic
Actions

Authored by epriestley on Apr 12 2020, 7:34 PM.

Tags

None

Referenced Files

	F13095196: D21095.diff
	Thu, Apr 25, 7:53 AM

	Unknown Object (File)
	Thu, Apr 11, 9:12 AM

	Unknown Object (File)
	Mar 5 2024, 1:20 AM

	Unknown Object (File)
	Feb 17 2024, 11:17 PM

	Unknown Object (File)
	Feb 14 2024, 7:28 PM

	Unknown Object (File)
	Jan 6 2024, 8:40 PM

	Unknown Object (File)
	Dec 27 2023, 1:22 PM

	Unknown Object (File)
	Dec 26 2023, 10:37 PM

View All 38 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits: rARC0f2e277cd986: Update "arc amend" for Toolsets

Summary

Ref T13490. Moves "arc amend" to Toolsets with modern ref/hardpoint code.

Test Plan

Ran "arc amend --show", "--revision", etc. Hit all the prompts and errors, probably?

Diff Detail

Repository

Branch

aflow10

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/runtime/ArcanistRuntime.php:802	XHP16	TODO Comment
Advice	src/runtime/ArcanistRuntime.php:828	XHP16	TODO Comment
Advice	src/toolset/query/ArcanistRuntimeHardpointQuery.php:87	XHP16	TODO Comment
Advice	src/workflow/ArcanistAmendWorkflow.php:170	XHP16	TODO Comment
Advice	src/workflow/ArcanistAmendWorkflow.php:172	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 24056
Build 33120: Run Core Tests
Build 33119: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 12 2020, 7:34 PM

Harbormaster completed remote builds in B24056: Diff 50238.Apr 12 2020, 7:35 PM

epriestley requested review of this revision.Apr 12 2020, 7:35 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2020, 8:48 PM

Closed by commit rARC0f2e277cd986: Update "arc amend" for Toolsets (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC0f2e277cd986: Update "arc amend" for Toolsets.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

browse/

query/

ArcanistBrowseCommitHardpointQuery.php

2 lines

ArcanistBrowseURIHardpointQuery.php

2 lines

query/

ArcanistCommitUpstreamHardpointQuery.php

2 lines

ArcanistMessageRevisionHardpointQuery.php

2 lines

ArcanistWorkflowGitHardpointQuery.php

2 lines

ArcanistWorkingCopyCommitHardpointQuery.php

2 lines

ref/

revision/

ArcanistRevisionCommitMessageHardpointQuery.php

2 lines

ArcanistRevisionRef.php

4 lines

ArcanistRevisionSymbolHardpointQuery.php

2 lines

user/

ArcanistUserRef.php

16 lines

ArcanistUserSymbolHardpointQuery.php

2 lines

repository/

api/

ArcanistGitAPI.php

4 lines

ArcanistRepositoryAPI.php

73 lines

runtime/

ArcanistRuntime.php

99 lines

toolset/

query/

	ArcanistRuntimeHardpointQuery.php
	ArcanistWorkflowHardpointQuery.php

23 lines

ArcanistWorkflowHardpointQuery.php

workflow/

ArcanistAmendWorkflow.php

388 lines

ArcanistWorkflow.php

67 lines

xsprintf/

17 lines

Diff 50238

src/__phutil_library_map__.php

Loading...

src/browse/query/ArcanistBrowseCommitHardpointQuery.php

Loading...

src/browse/query/ArcanistBrowseURIHardpointQuery.php

Loading...

src/query/ArcanistCommitUpstreamHardpointQuery.php

Loading...

src/query/ArcanistMessageRevisionHardpointQuery.php

Loading...

src/query/ArcanistWorkflowGitHardpointQuery.php

Loading...

src/query/ArcanistWorkingCopyCommitHardpointQuery.php

Loading...

src/ref/revision/ArcanistRevisionCommitMessageHardpointQuery.php

Loading...

src/ref/revision/ArcanistRevisionRef.php

Loading...

src/ref/revision/ArcanistRevisionSymbolHardpointQuery.php

Loading...

src/ref/user/ArcanistUserRef.php

Loading...

src/ref/user/ArcanistUserSymbolHardpointQuery.php

Loading...

src/repository/api/ArcanistGitAPI.php

Loading...

src/repository/api/ArcanistRepositoryAPI.php

Loading...

src/runtime/ArcanistRuntime.php

Loading...

src/toolset/query/ArcanistRuntimeHardpointQuery.php

Loading...

src/toolset/query/ArcanistWorkflowHardpointQuery.php

Loading...

src/workflow/ArcanistAmendWorkflow.php

Loading...

src/workflow/ArcanistWorkflow.php

Loading...

src/xsprintf/tsprintf.php

Loading...