Fix an out-of-date API call on the destruction pathway for Pholio mocks
ClosedPublic
Actions

Authored by epriestley on Apr 10 2020, 3:00 PM.

Details

Reviewers: None
Commits: rPc3be82fe6e09: Fix an out-of-date API call on the destruction pathway for Pholio mocks

Summary

See https://discourse.phabricator-community.org/t/destroying-a-mock-using-bin-remove-destroy-mx-gives-an-error/3728.

Currently, Pholio calls an older API method on the mock destruction pathway. This call was introduced in D19911 but the callsite was only partially updated in D19914.

Test Plan

Ran "bin/remove destroy Mx" to destroy a mock. Before: fatal with a bad call; after: clean destruction.

Diff Detail

Repository

rP Phabricator

Branch

mock1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24035
Build 33084: Run Core Tests
Build 33083: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 10 2020, 3:00 PM

epriestley mentioned this in D19914: Make Images in Pholio refer to mocks by PHID instead of ID.Apr 10 2020, 3:01 PM

Harbormaster completed remote builds in B24035: Diff 50217.Apr 10 2020, 3:01 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2020, 3:01 PM

epriestley requested review of this revision.

Closed by commit rPc3be82fe6e09: Fix an out-of-date API call on the destruction pathway for Pholio mocks (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPc3be82fe6e09: Fix an out-of-date API call on the destruction pathway for Pholio mocks.

Revision Contents
Changeset List

Path

Size

src/

applications/

pholio/

storage/

PholioMock.php

2 lines

Diff 50217

View Options

src/applications/pholio/storage/PholioMock.php

Fix an out-of-date API call on the destruction pathway for Pholio mocksClosedPublicActions