Differential D21076

Revert "Compress requests from the Conduit client to Phabricator"
ClosedPublic
Actions

Authored by epriestley on Apr 9 2020, 7:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 25, 7:30 PM

	Unknown Object (File)
	Sat, Jan 25, 7:35 AM

	Unknown Object (File)
	Sat, Jan 25, 6:56 AM

	Unknown Object (File)
	Sat, Jan 25, 6:56 AM

	Unknown Object (File)
	Sat, Jan 25, 6:56 AM

	Unknown Object (File)
	Sat, Jan 25, 6:56 AM

	Unknown Object (File)
	Sat, Jan 25, 3:50 AM

	Unknown Object (File)
	Fri, Jan 24, 1:19 AM

Subscribers

None

Details

Reviewers: None
Commits: rARCf56c6bde2b45: Revert "Compress requests from the Conduit client to Phabricator"

Summary

This reverts commit 7e25288f496887a78d1ba4a54753c2cca09a6336. See T13507 for discussion, shortly.

This needs to be switched to capability detection because some server configurations can not actually accept these requests.

Test Plan

Straight revert.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24023
Build 33066: Run Core Tests
Build 33065: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 9 2020, 7:22 PM

Harbormaster completed remote builds in B24023: Diff 50205.Apr 9 2020, 7:22 PM

epriestley requested review of this revision.Apr 9 2020, 7:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 9 2020, 7:25 PM

Closed by commit rARCf56c6bde2b45: Revert "Compress requests from the Conduit client to Phabricator" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCf56c6bde2b45: Revert "Compress requests from the Conduit client to Phabricator".

epriestley mentioned this in D21119: If the Conduit server asserts it has the "gzip" capability, compress requests.Apr 14 2020, 11:45 PM

epriestley mentioned this in rARC377ed2ed8db7: If the Conduit server asserts it has the "gzip" capability, compress requests.Apr 14 2020, 11:51 PM

Revision Contents
Changeset List

Path

Size

src/

conduit/

ConduitClient.php

15 lines

Diff 50205

src/conduit/ConduitClient.php

Loading...