Page MenuHomePhabricator
Differential D21074

Trivially update "arc branch/feature" and "arc browse" for Toolsets
ClosedPublic
Actions

Authored by epriestley on Apr 8 2020, 7:28 PM.

Details

Reviewers
None
Maniphest Tasks
T11968: Decide the fate of FutureGraph
T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits
rARC391c1643134a: Trivially update "arc branch/feature" and "arc browse" for Toolsets
Summary

Ref T11968. Ref T13490. These are the workflows which currently use the intermediate-level hardpoint code (which made hardpoints formal, but didn't do the yield stuff).

Move toward updating them by doing some basic bookkeeping, with a few compatibility adjustments to the parent Workflow class.

Test Plan

Ran "arc branch" and "arc browse" with various arguments.

Diff Detail

Repository
rARC Arcanist
Branch
hpx1
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/workflow/ArcanistFeatureWorkflow.php:3XHP87Class Not `abstract` Or `final`
Unit
Tests Passed
Build Status
Buildable 24021
Build 33062: Run Core Tests
Build 33061: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 8 2020, 7:28 PM
Harbormaster completed remote builds in B24021: Diff 50203.Apr 8 2020, 7:29 PM
epriestley requested review of this revision.Apr 8 2020, 7:29 PM
epriestley added a child revision: D21075: Rename "getWorkingCopy()" to "getWorkingCopyIdentity()" in Arcanist.Apr 8 2020, 7:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2020, 11:23 AM
This revision was landed with ongoing or failed builds.
Closed by commit rARC391c1643134a: Trivially update "arc branch/feature" and "arc browse" for Toolsets (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC391c1643134a: Trivially update "arc branch/feature" and "arc browse" for Toolsets.

Revision Contents
Changeset List

Diff 50203

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/browse/workflow/ArcanistBrowseWorkflow.php

Loading...
View Options

src/workflow/ArcanistFeatureWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility