Compress requests from the Conduit client to Phabricator
ClosedPublic
Actions

Authored by epriestley on Apr 8 2020, 4:21 PM.

Details

Reviewers: None
Maniphest Tasks: T13507: Compress Conduit client requests
Commits: rARC7e25288f4968: Compress requests from the Conduit client to Phabricator

Summary

Ref T13507. Enable compression in the body of Conduit requests if we have client support for it; we expect the server should always support it.

Test Plan

Created this revision, ran random "arc" commands that use Conduit. Added debugging code, saw payload size drop.

Diff Detail

Repository

rARC Arcanist

Branch

ref4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24016
Build 33056: Run Core Tests
Build 33055: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 8 2020, 4:21 PM

Harbormaster completed remote builds in B24016: Diff 50198.Apr 8 2020, 4:21 PM

epriestley requested review of this revision.Apr 8 2020, 4:21 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 8 2020, 4:24 PM

Closed by commit rARC7e25288f4968: Compress requests from the Conduit client to Phabricator (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC7e25288f4968: Compress requests from the Conduit client to Phabricator.

epriestley added a reverting change: D21076: Revert "Compress requests from the Conduit client to Phabricator".Apr 9 2020, 7:22 PM

epriestley added a reverting change: rARCf56c6bde2b45: Revert "Compress requests from the Conduit client to Phabricator".Apr 9 2020, 7:25 PM

epriestley mentioned this in D21119: If the Conduit server asserts it has the "gzip" capability, compress requests.Apr 14 2020, 11:45 PM

epriestley mentioned this in rARC377ed2ed8db7: If the Conduit server asserts it has the "gzip" capability, compress requests.Apr 14 2020, 11:51 PM

Revision Contents
Changeset List

Path

Size

src/

conduit/

ConduitClient.php

15 lines

Diff 50198

View Options

src/conduit/ConduitClient.php

Compress requests from the Conduit client to PhabricatorClosedPublicActions